2014-07-05 19:26:43

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH] machine_power_off: not only local_irq_disable but also do disable preemption

On Sun, Jul 06, 2014 at 12:34:14AM +0530, pawandeep oza wrote:
> no this is not a generic code bug, because only in this scenerio, problem
> might happen.
> because other core is plugged out and now there is no chance that it can
> release the spin_lock it would have held previously.
>
> so this core must run with preemption and interrupt disabled.
>
> this is only applicable for shutdown, not for any other scenerio.

No. See my reply I just sent. Preempting when local interrupts
disabled is a bug.

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.