2014-06-26 15:00:05

by Guido Martínez

Subject: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.

This patch changes the iteration to only probe nodes marked as
available.

Signed-off-by: Guido Martínez <[email protected]>
---
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}

- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {

if (!child->name)
continue;
--
2.0.0

2014-06-26 16:37:56

by Ezequiel Garcia

Subject: Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

On 26 Jun 12:02 PM, Guido Mart?nez wrote:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Mart?nez <[email protected]>

Just a nit: the commit title doesn't match the recent commits. If you
run "git log" on this file, you'll find the pattern should be something
like:

"ARM: OMAP2+: GPMC should only probe enabled devices"

Other than this, the patch looks correct.

Thanks,
--
Ezequiel Garcia, VanguardiaSur
http://www.vanguardiasur.com.ar

2014-07-02 05:34:08

by Gupta, Pekon

Subject: RE: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes

>From: Ezequiel Garc?a [mailto:[email protected]]
>>On 26 Jun 12:02 PM, Guido Mart?nez wrote:
>> Currently, child nodes of the gpmc node are iterated and probed
>> regardless of their 'status' property. This means adding 'status =
>> "disabled";' has no effect.
>>
>> This patch changes the iteration to only probe nodes marked as
>> available.
>>
>> Signed-off-by: Guido Mart?nez <[email protected]>
>
>Just a nit: the commit title doesn't match the recent commits. If you
>run "git log" on this file, you'll find the pattern should be something
>like:
>
>"ARM: OMAP2+: GPMC should only probe enabled devices"
>
>Other than this, the patch looks correct.
>
Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.

Tested-by: Pekon Gupta <[email protected]>

with regards, pekon

2014-07-02 13:33:05

by Guido Martínez

Subject: [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices

Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.

This patch changes the iteration to only probe nodes marked as
available.

Signed-off-by: Guido Martínez <[email protected]>
---
v2: Make patch title consistent with previous gpmc patches

arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}

- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {

if (!child->name)
continue;
--
2.0.0

2014-07-07 10:51:03

by Tony Lindgren

Subject: Re: [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices

* Guido Martínez <[email protected]> [140702 06:34]:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Martínez <[email protected]>
> ---
> v2: Make patch title consistent with previous gpmc patches

Thanks applying into omap-for-v3.16/fixes.

Tony

> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 2c0c281..8bc1338 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
> return ret;
> }
>
> - for_each_child_of_node(pdev->dev.of_node, child) {
> + for_each_available_child_of_node(pdev->dev.of_node, child) {
>
> if (!child->name)
> continue;
> --
> 2.0.0
>