2014-07-02 20:23:45

by Fabian Frédérick

Subject: [PATCH 1/1] ipconfig: add static to local variable

ic_dev_xid is only used in ipconfig.c

Cc: "David S. Miller" <[email protected]>
Cc: Alexey Kuznetsov <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
net/ipv4/ipconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index b3e86ea..f0f3f9f 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -143,7 +143,7 @@ __be32 ic_servaddr = NONE; /* Boot server IP address */
__be32 root_server_addr = NONE; /* Address of NFS server */
u8 root_server_path[256] = { 0, }; /* Path to mount as root */

-__be32 ic_dev_xid; /* Device under configuration */
+static __be32 ic_dev_xid; /* Device under configuration */

/* vendor class identifier */
static char vendor_class_identifier[253] __initdata;
--
1.8.4.5

2014-07-08 18:30:53

by David Miller

Subject: Re: [PATCH 1/1] ipconfig: add static to local variable

From: Fabian Frederick <[email protected]>
Date: Wed, 2 Jul 2014 22:22:20 +0200

> ic_dev_xid is only used in ipconfig.c
>
> Cc: "David S. Miller" <[email protected]>
> Cc: Alexey Kuznetsov <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>

Applied to net-next, thanks.