2014-07-08 06:50:18

by Hayes Wang

Subject: [PATCH net] r8152: wake up the device before dumping the hw counter

The device should be waked up from runtime suspend before dumping
the hw counter.

Signed-off-by: Hayes Wang <[email protected]>
---
drivers/net/usb/r8152.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 2543196..a795ecf 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3204,8 +3204,13 @@ static void rtl8152_get_ethtool_stats(struct net_device *dev,
struct r8152 *tp = netdev_priv(dev);
struct tally_counter tally;

+ if (usb_autopm_get_interface(tp->intf) < 0)
+ return;
+
generic_ocp_read(tp, PLA_TALLYCNT, sizeof(tally), &tally, MCU_TYPE_PLA);

+ usb_autopm_put_interface(tp->intf);
+
data[0] = le64_to_cpu(tally.tx_packets);
data[1] = le64_to_cpu(tally.rx_packets);
data[2] = le64_to_cpu(tally.tx_errors);
--
1.9.3

2014-07-09 02:55:52

by David Miller

Subject: Re: [PATCH net] r8152: wake up the device before dumping the hw counter

From: Hayes Wang <[email protected]>
Date: Tue, 8 Jul 2014 14:49:28 +0800

> The device should be waked up from runtime suspend before dumping
> the hw counter.
>
> Signed-off-by: Hayes Wang <[email protected]>

Applied, thanks.