2014-07-02 15:21:29

by Suthikulpanit, Suravee

[permalink] [raw]
Subject: [PATCH 0/3 V2] irqchip: gic: Introduce ARM GICv2m MSI(-X) support

From: Suravee Suthikulpanit <[email protected]>

This patch set introduces support for MSI(-X) in GICv2m specification,
which is implemented in some variation of GIC400 (e.g. gic-400+).

This depends on and has been tested with the V7 of "Add support for PCI in AArch64"
(https://lkml.org/lkml/2014/3/14/320).

Changes in V2:
Re-architect the code to:
* Use irq_chip for gicv2m instead of using the gic_chip (per Marc suggestion).
* Remove the overwriting of arch_setup_msi_irq and arch_setup_msi_irqs
(per Marc suggestion).
* Add devicetree matching for gic-400-plus for v2m stuff instread of
re-using gic-400 just to be clear.
* Misc fix/clean up per Mark Rutland and Marc Zyngier comments

Suravee Suthikulpanit (3):
irqchip: gic: Add binding probe for ARM GIC400
irqchip: gic: Restructuring ARM GIC code
irqchip: gic: Add supports for ARM GICv2m MSI(-X)

Documentation/devicetree/bindings/arm/gic.txt | 19 +-
drivers/irqchip/Kconfig | 6 +
drivers/irqchip/Makefile | 1 +
drivers/irqchip/irq-gic-v2m.c | 248 ++++++++++++++++++++++++++
drivers/irqchip/irq-gic-v2m.h | 13 ++
drivers/irqchip/irq-gic.c | 88 +++++----
drivers/irqchip/irq-gic.h | 60 +++++++
7 files changed, 395 insertions(+), 40 deletions(-)
create mode 100644 drivers/irqchip/irq-gic-v2m.c
create mode 100644 drivers/irqchip/irq-gic-v2m.h
create mode 100644 drivers/irqchip/irq-gic.h

--
1.9.0


2014-07-02 15:21:36

by Suthikulpanit, Suravee

[permalink] [raw]
Subject: [PATCH 1/3 V2] irqchip: gic: Add binding probe for ARM GIC400

From: Suravee Suthikulpanit <[email protected]>

Add new Irqchip declaration for GIC400. This was mentioned in
gic binding documentation, but there is not code to support it.

Signed-off-by: Suravee Suthikulpanit <[email protected]>
---
drivers/irqchip/irq-gic.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 7e11c9d..adc86de 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1071,6 +1071,8 @@ gic_of_init(struct device_node *node, struct device_node *parent)
gic_cnt++;
return 0;
}
+
+IRQCHIP_DECLARE(arm_gic_400, "arm,gic-400", gic_of_init);
IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init);
IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init);
IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init);
--
1.9.0

2014-07-08 22:37:24

by Jason Cooper

[permalink] [raw]
Subject: Re: [PATCH 0/3 V2] irqchip: gic: Introduce ARM GICv2m MSI(-X) support

Suravee,

On Wed, Jul 02, 2014 at 10:21:05AM -0500, [email protected] wrote:
> From: Suravee Suthikulpanit <[email protected]>
>
> This patch set introduces support for MSI(-X) in GICv2m specification,
> which is implemented in some variation of GIC400 (e.g. gic-400+).
>
> This depends on and has been tested with the V7 of "Add support for PCI in AArch64"
> (https://lkml.org/lkml/2014/3/14/320).
>
> Changes in V2:
> Re-architect the code to:
> * Use irq_chip for gicv2m instead of using the gic_chip (per Marc suggestion).
> * Remove the overwriting of arch_setup_msi_irq and arch_setup_msi_irqs
> (per Marc suggestion).
> * Add devicetree matching for gic-400-plus for v2m stuff instread of
> re-using gic-400 just to be clear.
> * Misc fix/clean up per Mark Rutland and Marc Zyngier comments
>
> Suravee Suthikulpanit (3):
> irqchip: gic: Add binding probe for ARM GIC400
> irqchip: gic: Restructuring ARM GIC code
> irqchip: gic: Add supports for ARM GICv2m MSI(-X)

I've now pulled in the first two patches of Marc's series into
irqchip/gic. Could you please rebase your changes on top of that?

Also, please get a handle on git send-email. This series had broken
threading and was sent out of order.

thx,

Jason.