2014-07-04 19:58:27

by Fabian Frédérick

Subject: [PATCH 1/1] staging: cxt1e1: remove null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Greg Kroah-Hartman <[email protected]>
Cc: Daeseok Youn <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/staging/cxt1e1/pmcc4_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/cxt1e1/pmcc4_drv.c b/drivers/staging/cxt1e1/pmcc4_drv.c
index 76bebdd..e738264 100644
--- a/drivers/staging/cxt1e1/pmcc4_drv.c
+++ b/drivers/staging/cxt1e1/pmcc4_drv.c
@@ -454,10 +454,7 @@ c4_cleanup (void)
pi = &ci->port[portnum];
c4_wq_port_cleanup (pi);
for (j = 0; j < MUSYCC_NCHANS; j++)
- {
- if (pi->chan[j])
- kfree(pi->chan[j]); /* free mch_t struct */
- }
+ kfree(pi->chan[j]); /* free mch_t struct */
kfree(pi->regram_saved);
}
kfree(ci->iqd_p_saved);
--
1.9.1

2014-07-08 23:34:22

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/1] staging: cxt1e1: remove null test before kfree

On Fri, Jul 04, 2014 at 09:58:15PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Daeseok Youn <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/staging/cxt1e1/pmcc4_drv.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)

This driver has been deleted in the tree, sorry.

greg k-h