2014-07-01 07:00:37

by Anil Belur

Subject: [PATCH 1/1] staging: speakup: main.c - use time_after()

From: Anil Belur <[email protected]>

- this patch fixes jiffies comparision with a safer function to prevent
any overflows

Signed-off-by: Anil Belur <[email protected]>
---
drivers/staging/speakup/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 7de79d5..0cd3cdb 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2067,7 +2067,7 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
if (up_flag)
goto out;
if (last_keycode == keycode &&
- last_spk_jiffy + MAX_DELAY > jiffies) {
+ time_after(last_spk_jiffy + MAX_DELAY, jiffies)) {
spk_close_press = 1;
offset = spk_shift_table[shift_info + 32];
/* double press? */
--
1.9.1

2014-07-08 23:47:19

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

On Tue, Jul 01, 2014 at 12:30:22PM +0530, Anil Belur wrote:
> From: Anil Belur <[email protected]>
>
> - this patch fixes jiffies comparision with a safer function to prevent
> any overflows
>
> Signed-off-by: Anil Belur <[email protected]>
> ---
> drivers/staging/speakup/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This change is already in my tree, what branch are you working against?

greg k-h