2014-07-13 00:56:06

by Lucas Tanure

[permalink] [raw]
Subject: [RESEND PATCH] staging: android: Clean up binder_buffer_size()

Kernel coding style. Remove useless else statement after return.

Signed-off-by: Lucas Tanure <[email protected]>
---
drivers/staging/android/binder.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index cfe4bc8..1a0966b 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -451,8 +451,7 @@ static size_t binder_buffer_size(struct binder_proc *proc,
{
if (list_is_last(&buffer->entry, &proc->buffers))
return proc->buffer + proc->buffer_size - (void *)buffer->data;
- else
- return (size_t)list_entry(buffer->entry.next,
+ return (size_t)list_entry(buffer->entry.next,
struct binder_buffer, entry) - (size_t)buffer->data;
}

--
2.0.1


2014-07-13 01:40:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [RESEND PATCH] staging: android: Clean up binder_buffer_size()

On Sat, Jul 12, 2014 at 09:50:09PM -0300, Lucas Tanure wrote:
> Kernel coding style. Remove useless else statement after return.
>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
> drivers/staging/android/binder.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

What tree are you making this patch against? Someone already has this
patch accepted into my staging-next branch, which means that linux-next
also should show this change in it.

thanks,

greg k-h