2014-07-13 14:55:29

by Lucas Tanure

Subject: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return.

Signed-off-by: Lucas Tanure <[email protected]>
---
drivers/staging/android/binder.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 14714a6..67c9847 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1210,24 +1210,23 @@ static void binder_send_failed_reply(struct binder_transaction *t,
target_thread->return_error);
}
return;
- } else {
- struct binder_transaction *next = t->from_parent;
+ }
+ struct binder_transaction *next = t->from_parent;

- binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
- "send failed reply for transaction %d, target dead\n",
- t->debug_id);
+ binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
+ "send failed reply for transaction %d, target dead\n",
+ t->debug_id);

- binder_pop_transaction(target_thread, t);
- if (next == NULL) {
- binder_debug(BINDER_DEBUG_DEAD_BINDER,
- "reply failed, no target thread at root\n");
- return;
- }
- t = next;
+ binder_pop_transaction(target_thread, t);
+ if (next == NULL) {
binder_debug(BINDER_DEBUG_DEAD_BINDER,
- "reply failed, no target thread -- retry %d\n",
- t->debug_id);
+ "reply failed, no target thread at root\n");
+ return;
}
+ t = next;
+ binder_debug(BINDER_DEBUG_DEAD_BINDER,
+ "reply failed, no target thread -- retry %d\n",
+ t->debug_id);
}
}

--
2.0.1

2014-07-13 16:31:16

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote:
> Kernel coding style. Remove useless else statement after return.
>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
> drivers/staging/android/binder.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)

Why the "RESEND"? What was wrong with the first patch? What is
different with this one?

confused,

greg k-h

2014-07-13 16:39:14

by Lucas Tanure

Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

I missed on trailing whitespace in first patch.
Didn't saw a ERROR: trailing whitespace in the first patch.

Sorry,
Thanks

--
Lucas Tanure
+55 (19) 988176559

2014-07-13 16:44:32

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 01:38:45PM -0300, Lucas Tanure wrote:
> I missed on trailing whitespace in first patch.
> Didn't saw a ERROR: trailing whitespace in the first patch.

Ok. Please, always say that this is a 'v2' patch, and what the
difference is between this one, and the previous version, otherwise I
have no idea what to do here.

thanks,

greg k-h

2014-07-13 19:02:54

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote:
> Kernel coding style. Remove useless else statement after return.
>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
> drivers/staging/android/binder.c | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)

You didn't compile this patch :(

Or if you did, you ignored the fact that it now adds a warning to the
kernel build process, which is not allowed. Please fix this up and
resend.

thanks,

greg k-h

2014-07-13 19:48:42

by Lucas Tanure

Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Sorry,
I didn't know. I will fix.

Thanks
--
Lucas Tanure
+55 (19) 988176559


On Sun, Jul 13, 2014 at 4:07 PM, Greg Kroah-Hartman
<[email protected]> wrote:
> On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote:
>> Kernel coding style. Remove useless else statement after return.
>>
>> Signed-off-by: Lucas Tanure <[email protected]>
>> ---
>> drivers/staging/android/binder.c | 27 +++++++++++++--------------
>> 1 file changed, 13 insertions(+), 14 deletions(-)
>
> You didn't compile this patch :(
>
> Or if you did, you ignored the fact that it now adds a warning to the
> kernel build process, which is not allowed. Please fix this up and
> resend.
>
> thanks,
>
> greg k-h