2014-07-15 03:02:01

by Daeseok Youn

[permalink] [raw]
Subject: [PATCH 1/8] staging: dgap: remove redundant error value check

The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check "retval" itself.

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/staging/dgap/dgap.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 32988a8..10bd0f2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -2181,10 +2181,7 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file,

spin_unlock_irqrestore(&ch->ch_lock, lock_flags);

- if (retval)
- return retval;
-
- return 0;
+ return retval;
}

/*
--
1.7.1