2014-07-15 23:24:52

by Bjorn Helgaas

[permalink] [raw]
Subject: [PATCH] Input: sirfsoc-onkey - fix GPL v2 license string typo

Per license_is_gpl_compatible(), the MODULE_LICENSE() string for GPL v2 is
"GPL v2", not "GPLv2". Use "GPL v2" so this module doesn't taint the
kernel.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/input/misc/sirfsoc-onkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
index e4104f9b2e6d..fed5102e1802 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -213,7 +213,7 @@ static struct platform_driver sirfsoc_pwrc_driver = {

module_platform_driver(sirfsoc_pwrc_driver);

-MODULE_LICENSE("GPLv2");
+MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Binghua Duan <[email protected]>, Xianglong Du <[email protected]>");
MODULE_DESCRIPTION("CSR Prima2 PWRC Driver");
MODULE_ALIAS("platform:sirfsoc-pwrc");


2014-07-18 17:19:23

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] Input: sirfsoc-onkey - fix GPL v2 license string typo

On Tue, Jul 15, 2014 at 05:24:45PM -0600, Bjorn Helgaas wrote:
> Per license_is_gpl_compatible(), the MODULE_LICENSE() string for GPL v2 is
> "GPL v2", not "GPLv2". Use "GPL v2" so this module doesn't taint the
> kernel.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Applied, thank you.

> ---
> drivers/input/misc/sirfsoc-onkey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> index e4104f9b2e6d..fed5102e1802 100644
> --- a/drivers/input/misc/sirfsoc-onkey.c
> +++ b/drivers/input/misc/sirfsoc-onkey.c
> @@ -213,7 +213,7 @@ static struct platform_driver sirfsoc_pwrc_driver = {
>
> module_platform_driver(sirfsoc_pwrc_driver);
>
> -MODULE_LICENSE("GPLv2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Binghua Duan <[email protected]>, Xianglong Du <[email protected]>");
> MODULE_DESCRIPTION("CSR Prima2 PWRC Driver");
> MODULE_ALIAS("platform:sirfsoc-pwrc");
>

--
Dmitry