2014-07-19 11:33:24

by Himangi Saraogi

[permalink] [raw]
Subject: [PATCH] uml: Eliminate NULL test after alloc_bootmem

alloc_bootmem and related functions never return NULL. Thus a NULL
test after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E;
statement S;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
... when != E
- if (E == NULL) S

Signed-off-by: Himangi Saraogi <[email protected]>
Acked-by: Julia Lawall <[email protected]>
---
arch/um/kernel/initrd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/um/kernel/initrd.c b/arch/um/kernel/initrd.c
index 55cead8..48bae81 100644
--- a/arch/um/kernel/initrd.c
+++ b/arch/um/kernel/initrd.c
@@ -37,8 +37,6 @@ static int __init read_initrd(void)
}

area = alloc_bootmem(size);
- if (area == NULL)
- return 0;

if (load_initrd(initrd, area, size) == -1)
return 0;
--
1.9.1