2014-07-20 01:16:35

by Sam Asadi

Subject: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed

A line over 80 issue fixed, which is a comment.

Signed-off-by: Sam Asadi <[email protected]>
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
index 602b7a1..13ff78c 100644
--- a/drivers/staging/comedi/drivers/adv_pci1710.c
+++ b/drivers/staging/comedi/drivers/adv_pci1710.c
@@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
devpriv->CntrlReg &= Control_CNT0;
devpriv->CntrlReg |= Control_SW;

- outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); /* reset any operations */
+ outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
+ /* reset any operations */
pci171x_start_pacer(dev, false);
outb(0, dev->iobase + PCI171x_CLRFIFO);
outb(0, dev->iobase + PCI171x_CLRINT);
--
1.9.1

2014-07-20 04:10:14

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed

On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote:
> A line over 80 issue fixed, which is a comment.
>
> Signed-off-by: Sam Asadi <[email protected]>
> ---
> drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index 602b7a1..13ff78c 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -723,7 +723,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
> devpriv->CntrlReg &= Control_CNT0;
> devpriv->CntrlReg |= Control_SW;
>
> - outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL); /* reset any operations */
> + outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
> + /* reset any operations */

That really doesn't make any sense now, does it?

Please put it _before_ the outw() call.

thanks,

greg k-h