2014-07-23 02:06:54

by Sam Asadi

Subject: [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted

A 'Missing a blank line after declarations' warning fixed by inserting
a blank line after struct pointer declaration.

Signed-off-by: Sam Asadi <[email protected]>
---
drivers/staging/comedi/drivers/amplc_pc236.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c b/drivers/staging/comedi/drivers/amplc_pc236.c
index c9a96ad..d0f81f8 100644
--- a/drivers/staging/comedi/drivers/amplc_pc236.c
+++ b/drivers/staging/comedi/drivers/amplc_pc236.c
@@ -515,6 +515,7 @@ static void pc236_detach(struct comedi_device *dev)
comedi_legacy_detach(dev);
} else if (is_pci_board(thisboard)) {
struct pci_dev *pcidev = comedi_to_pci_dev(dev);
+
if (dev->irq)
free_irq(dev->irq, dev);
comedi_pci_disable(dev);
--
1.7.10.4

2014-07-24 00:55:13

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/1] Staging: comedi: amplc_pc236: a blank line inserted

On Wed, Jul 23, 2014 at 05:06:28AM +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' warning fixed by inserting
> a blank line after struct pointer declaration.
>
> Signed-off-by: Sam Asadi <[email protected]>
> ---
> drivers/staging/comedi/drivers/amplc_pc236.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c b/drivers/staging/comedi/drivers/amplc_pc236.c
> index c9a96ad..d0f81f8 100644
> --- a/drivers/staging/comedi/drivers/amplc_pc236.c
> +++ b/drivers/staging/comedi/drivers/amplc_pc236.c
> @@ -515,6 +515,7 @@ static void pc236_detach(struct comedi_device *dev)
> comedi_legacy_detach(dev);
> } else if (is_pci_board(thisboard)) {
> struct pci_dev *pcidev = comedi_to_pci_dev(dev);
> +
> if (dev->irq)
> free_irq(dev->irq, dev);
> comedi_pci_disable(dev);

This is already in my tree, sorry :(

greg k-h