2014-07-01 19:59:01

by Fabian Frédérick

Subject: [PATCH 1/1] IB/mlx5: use ARRAY_SIZE instead of sizeof/sizeof[0]

use macro definition

Cc: Eli Cohen <[email protected]>
Cc: Roland Dreier <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/infiniband/hw/mlx5/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index d13ddf1..e9a3250 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2501,7 +2501,7 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
spin_lock_irqsave(&qp->sq.lock, flags);

for (nreq = 0; wr; nreq++, wr = wr->next) {
- if (unlikely(wr->opcode >= sizeof(mlx5_ib_opcode) / sizeof(mlx5_ib_opcode[0]))) {
+ if (unlikely(wr->opcode >= ARRAY_SIZE(mlx5_ib_opcode))) {
mlx5_ib_warn(dev, "\n");
err = -EINVAL;
*bad_wr = wr;
--
1.9.1

2014-07-02 06:20:03

by Eli Cohen

Subject: Re: [PATCH 1/1] IB/mlx5: use ARRAY_SIZE instead of sizeof/sizeof[0]

Acked-by: Eli Cohen <[email protected]>

On Tue, Jul 01, 2014 at 09:58:44PM +0200, Fabian Frederick wrote:
> use macro definition
>

2014-07-24 09:43:39

by Eli Cohen

Subject: Re: [PATCH 1/1] IB/mlx5: use ARRAY_SIZE instead of sizeof/sizeof[0]

On Tue, Jul 01, 2014 at 09:58:44PM +0200, Fabian Frederick wrote:
> use macro definition

Acked-by: Eli Cohen <[email protected]>