2014-07-24 15:56:16

by Benjamin LaHaise

[permalink] [raw]
Subject: Re: [RESEND PATCH 3/4] aio: fix some comments

On Wed, Jul 23, 2014 at 06:03:53PM +0800, Gu Zheng wrote:
> The function comments of aio_run_iocb and aio_read_events are out of date, so
> fix them here.

Thanks Gu -- applied to my aio-next tree at
git://git.kvack.org/~bcrl/aio-next.git .

-ben

> Reviewed-by: Jeff Moyer <[email protected]>
> Signed-off-by: Gu Zheng <[email protected]>
> ---
> fs/aio.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index e0f838d..f1fede2 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1044,7 +1044,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2)
> }
> EXPORT_SYMBOL(aio_complete);
>
> -/* aio_read_events
> +/* aio_read_events_ring
> * Pull an event off of the ioctx's event ring. Returns the number of
> * events fetched
> */
> @@ -1296,9 +1296,8 @@ static ssize_t aio_setup_single_vector(struct kiocb *kiocb,
> }
>
> /*
> - * aio_setup_iocb:
> - * Performs the initial checks and aio retry method
> - * setup for the kiocb at the time of io submission.
> + * aio_run_iocb:
> + * Performs the initial checks and io submission.
> */
> static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode,
> char __user *buf, bool compat)
> --
> 1.7.7

--
"Thought is the essence of where you are now."