2014-07-24 20:19:47

by Himangi Saraogi

Subject: [PATCH] neigh: remove exceptional & on function name

In this file, function names are otherwise used as pointers without &.

A simplified version of the Coccinelle semantic patch that makes this
change is as follows:

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Himangi Saraogi <[email protected]>
Acked-by: Julia Lawall <[email protected]>
---
net/ipv6/ndisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index b7ece27..339078f 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1768,7 +1768,7 @@ int __init ndisc_init(void)

#ifdef CONFIG_SYSCTL
err = neigh_sysctl_register(NULL, &nd_tbl.parms,
- &ndisc_ifinfo_sysctl_change);
+ ndisc_ifinfo_sysctl_change);
if (err)
goto out_unregister_pernet;
out:
--
1.9.1

2014-07-25 06:25:34

by David Miller

Subject: Re: [PATCH] neigh: remove exceptional & on function name

From: Himangi Saraogi <[email protected]>
Date: Fri, 25 Jul 2014 01:49:37 +0530

> In this file, function names are otherwise used as pointers without &.
>
> A simplified version of the Coccinelle semantic patch that makes this
> change is as follows:
...
> Signed-off-by: Himangi Saraogi <[email protected]>
> Acked-by: Julia Lawall <[email protected]>

2014-07-25 06:25:44

by David Miller

Subject: Re: [PATCH] neigh: remove exceptional & on function name

From: Himangi Saraogi <[email protected]>
Date: Fri, 25 Jul 2014 01:49:37 +0530

> In this file, function names are otherwise used as pointers without &.
>
> A simplified version of the Coccinelle semantic patch that makes this
> change is as follows:
...
> Signed-off-by: Himangi Saraogi <[email protected]>
> Acked-by: Julia Lawall <[email protected]>

Applied.