2014-07-23 19:03:38

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

Fix following sh-allmodconfig errors reported on kisskb
"
drivers/built-in.o: In function `ion_vm_fault':
ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn'
drivers/built-in.o: In function `ion_buffer_sync_for_device':
ion.c:(.text+0x1f316bc): undefined reference to `zap_page_range'
make: *** [vmlinux] Error 1
"

Signed-off-by: Fabian Frederick <[email protected]>
---

This is untested.

drivers/staging/android/ion/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 0a6e4d03..3452346 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -1,6 +1,6 @@
menuconfig ION
bool "Ion Memory Manager"
- depends on HAVE_MEMBLOCK && HAS_DMA
+ depends on HAVE_MEMBLOCK && HAS_DMA && MMU
select GENERIC_ALLOCATOR
select DMA_SHARED_BUFFER
---help---
--
1.8.4.5

2014-07-24 22:02:56

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote:
> Fix following sh-allmodconfig errors reported on kisskb
> "
> drivers/built-in.o: In function `ion_vm_fault':
> ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn'
> drivers/built-in.o: In function `ion_buffer_sync_for_device':
> ion.c:(.text+0x1f316bc): undefined reference to `zap_page_range'
> make: *** [vmlinux] Error 1
> "
>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
>
> This is untested.

I'd like to see it tested before I apply it...

2014-07-28 13:56:12

by Fabian Frédérick

Subject: Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

> On 25 July 2014 at 00:02 Greg Kroah-Hartman <[email protected]>
> wrote:
>
>
> On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote:
> > Fix following sh-allmodconfig errors reported on kisskb
> > "
> > drivers/built-in.o: In function `ion_vm_fault':
> > ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn'
> > drivers/built-in.o: In function `ion_buffer_sync_for_device':
> > ion.c:(.text+0x1f316bc): undefined reference to `zap_page_range'
> > make: *** [vmlinux] Error 1
> > "
> >
> > Signed-off-by: Fabian Frederick <[email protected]>
> > ---
> >
> > This is untested.
>
> I'd like to see it tested before I apply it...

Hello Greg,
       
        I did the following compilation tests:
       
        -sh/allyesconfig/cross-compile: no longer tries to compile ion with this
patch.
(MMU is only selected on !CPU_SH2 sub-type)

        -sh/SH-x3 subtype/cross-compile (->mmu on): compilation ok

        -x86_64 Compilation ok.
       
Do you need more testing ?

Regards,
Fabian