Hello Kernel Developers!
I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula.
Signed-off-by: Liviu Itoafa <[email protected]>
Thank you
Fix your From header and read paragraph 1 of
Documentation/email-clients.txt
regards,
dan carpenter
Can you folks please stop this challenge Bullshit? More checkpatch
fixes is not something we'll need at all.
Thanks you!
Hi Christoph,
What kind of things that you think a newbie can fix ?
Thanks
--
Lucas Tanure
+55 (19) 988176559
On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig <[email protected]> wrote:
> Can you folks please stop this challenge Bullshit? More checkpatch
> fixes is not something we'll need at all.
>
> Thanks you!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
On 7/28/14, Lucas Tanure <[email protected]> wrote:
> Hi Christoph,
>
> What kind of things that you think a newbie can fix ?
You can start working on fixing the pci_map_* and dma_map_* return
value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still
missing that...
> Thanks
> --
> Lucas Tanure
> +55 (19) 988176559
>
>
> On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig <[email protected]>
> wrote:
>> Can you folks please stop this challenge Bullshit? More checkpatch
>> fixes is not something we'll need at all.
>>
>> Thanks you!
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
>> in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
--
Regards,
Denis
On Mon, Jul 28, 2014 at 05:53:19AM -0700, Christoph Hellwig wrote:
> Can you folks please stop this challenge Bullshit? More checkpatch
> fixes is not something we'll need at all.
Greg and Dan have previously said that the staging tree is a good place
for newcomers to submit checkpatch cleanup patches. However, I think
there are a few tweaks that could be made to the Eudyptula Challenge to
avoid this noise/frustration:
- No need to send to lkml, the staging tree ML is probably fine.
- Don't mention Eudyptula Challenge, it's not relevant to the patch.
* It looks like you want a cookie. We have none.
- Submit the patch to the Challenge admins first for review. This
patch submission should have never made the cut.
- No S-o-B
- MIME attachment
- Subject line is just wrong
- Full name missing in From:
I've worked with several participants of the challenge and never saw
this many things wrong with a patch submission. Either the admins are
dropping the ball, or this participant got loose somehow. :)
It makes me wonder if they should start with a git workflow from day
one? It would prevent a lot of these avoidable mistakes.
thx,
Jason.