2014-07-30 07:07:22

by Zefan Li

Subject: [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()

The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.

Reported-by: Mike Qiu <[email protected]>
Tested-by: Mike Qiu <[email protected]>
Signed-off-by: Li Zefan <[email protected]>
---
kernel/cpuset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 53a9bbf..baa155c 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1136,7 +1136,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
mutex_unlock(&callback_mutex);

WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
- nodes_equal(cp->mems_allowed, cp->effective_mems));
+ !nodes_equal(cp->mems_allowed, cp->effective_mems));

update_tasks_nodemask(cp);

--
1.8.0.2

2014-07-30 15:27:45

by Tejun Heo

Subject: Re: [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()

On Wed, Jul 30, 2014 at 03:07:13PM +0800, Li Zefan wrote:
> The WARN_ON() is used to check if we break the legal hierarchy, on
> which the effective mems should be equal to configured mems.
>
> Reported-by: Mike Qiu <[email protected]>
> Tested-by: Mike Qiu <[email protected]>
> Signed-off-by: Li Zefan <[email protected]>

Applied to cgroup/for-3.17.

Thanks.

--
tejun