2014-07-30 21:33:54

by Fernando Apesteguia

Subject: [PATCH] Staging: rtl8192u: Staticfy debug method.

From: Fernando Apesteguia <[email protected]>

Add static to debug method.

Signed-off-by: Fernando Apesteguia <[email protected]>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..c732a67 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)


/* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
{
int i;
for (i = 0; i < 63; i++)
--
1.7.9.5

2014-07-31 00:05:57

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

On Wed, Jul 30, 2014 at 11:33:41PM +0200, [email protected] wrote:
> From: Fernando Apesteguia <[email protected]>
>
> Add static to debug method.
>
> Signed-off-by: Fernando Apesteguia <[email protected]>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 7640386..c732a67 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
>
>
> /* this is only for debug */
> -void dump_eprom(struct net_device *dev)
> +static void dump_eprom(struct net_device *dev)
> {
> int i;
> for (i = 0; i < 63; i++)

Someone sent this patch just before you :(

2014-07-31 08:21:08

by Dan Carpenter

Subject: Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

You need to compile these things before sending them...

This adds a GCC warning about uncalled functions.

regards,
dan carpenter

2014-07-31 09:10:35

by Fernando Apesteguia

Subject: Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

El 31/07/2014 10:21, "Dan Carpenter" <[email protected]> escribió:
>
> You need to compile these things before sending them...
>
> This adds a GCC warning about uncalled functions.

Sorry, but I did compile it with

make C=1 M=drivers/staging

But for the function to be called, DEBUG_EPROM must be defined and I
had it defined. That's why I overlooked the warning.

Apologies.
>
> regards,
> dan carpenter
>

2014-07-31 10:22:38

by Dan Carpenter

Subject: Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

On Thu, Jul 31, 2014 at 11:10:33AM +0200, Fernando Apestegu?a wrote:
> El 31/07/2014 10:21, "Dan Carpenter" <[email protected]> escribi?:
> >
> > You need to compile these things before sending them...
> >
> > This adds a GCC warning about uncalled functions.
>
> Sorry, but I did compile it with
>
> make C=1 M=drivers/staging
>
> But for the function to be called, DEBUG_EPROM must be defined and I
> had it defined. That's why I overlooked the warning.

Ah. Ok.

regards,
dan carpenter