On Mon, Sep 29, 2014 at 01:04:48PM +0100, [email protected] wrote:
> From: "chunyan.zhang" <[email protected]>
>
> Adds the device-tree documentation for Spreadtrum's serial.
>
> Signed-off-by: chunyan.zhang <[email protected]>
> ---
> .../devicetree/bindings/serial/of-serial.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt
> index 7705477..a0bb1d1 100644
> --- a/Documentation/devicetree/bindings/serial/of-serial.txt
> +++ b/Documentation/devicetree/bindings/serial/of-serial.txt
> @@ -14,6 +14,7 @@ Required properties:
> - "altr,16550-FIFO32"
> - "altr,16550-FIFO64"
> - "altr,16550-FIFO128"
> + - "sprd,serial"
Is there not a more specific name? I'd imagine you might build a
different uart in future.
I didn't spot "sprd" in vendor-prefixes.txt in mainline. Is there a
patch adding that?
Mark.
> - "serial" if the port type is unknown.
> - reg : offset and length of the register set for the device.
> - interrupts : should contain uart interrupt.
> --
> 1.7.9.5
>
>
On 2014年10月01日 19:21, Mark Rutland wrote:
>> diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt
>> >index 7705477..a0bb1d1 100644
>> >--- a/Documentation/devicetree/bindings/serial/of-serial.txt
>> >+++ b/Documentation/devicetree/bindings/serial/of-serial.txt
>> >@@ -14,6 +14,7 @@ Required properties:
>> > - "altr,16550-FIFO32"
>> > - "altr,16550-FIFO64"
>> > - "altr,16550-FIFO128"
>> >+ - "sprd,serial"
> Is there not a more specific name? I'd imagine you might build a
> different uart in future.
AFAIK, sprd's uart is re-used the same ip core in ARM 32bit chip.
so it is neither 16550 or pl011 compatible.
>
> I didn't spot "sprd" in vendor-prefixes.txt in mainline. Is there a
> patch adding that?
sorry for missing it. we'll add it at patch V2.
thanks for reviewing! :)
>
> Mark.
>