2014-07-29 14:25:41

by Thierry Reding

[permalink] [raw]
Subject: [PATCH] ARM: tegra: Move AHB Kconfig to drivers/amba

From: Thierry Reding <[email protected]>

This will allow the Kconfig option to be shared among 32-bit and 64-bit
ARM.

Signed-off-by: Thierry Reding <[email protected]>
---
arch/arm/mach-tegra/Kconfig | 8 --------
drivers/amba/Kconfig | 11 +++++++++++
2 files changed, 11 insertions(+), 8 deletions(-)
create mode 100644 drivers/amba/Kconfig

diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 052fba07a3cb..fae2eb2f52ea 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -64,12 +64,4 @@ config ARCH_TEGRA_124_SOC
Support for NVIDIA Tegra T124 processor family, based on the
ARM CortexA15MP CPU

-config TEGRA_AHB
- bool "Enable AHB driver for NVIDIA Tegra SoCs"
- default y
- help
- Adds AHB configuration functionality for NVIDIA Tegra SoCs,
- which controls AHB bus master arbitration and some
- performance parameters(priority, prefech size).
-
endif
diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig
new file mode 100644
index 000000000000..3f7350a03708
--- /dev/null
+++ b/drivers/amba/Kconfig
@@ -0,0 +1,11 @@
+if ARM_AMBA
+
+config TEGRA_AHB
+ bool "Enable AHB driver for NVIDIA Tegra SoCs"
+ default y if ARCH_TEGRA
+ help
+ Adds AHB configuration functionality for NVIDIA Tegra SoCs,
+ which controls AHB bus master arbitration and some performance
+ parameters (priority, prefetch size).
+
+endif
--
2.0.2


2014-07-29 16:21:04

by Stephen Warren

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: Move AHB Kconfig to drivers/amba

On 07/29/2014 08:25 AM, Thierry Reding wrote:
> From: Thierry Reding <[email protected]>
>
> This will allow the Kconfig option to be shared among 32-bit and 64-bit
> ARM.

This seems fine to me. I'd expect to apply it for 3.18, provided I get
an ack from Russell as drivers/amba maintainer (hence CCing him without
trimming the quote).

> Signed-off-by: Thierry Reding <[email protected]>
> ---
> arch/arm/mach-tegra/Kconfig | 8 --------
> drivers/amba/Kconfig | 11 +++++++++++
> 2 files changed, 11 insertions(+), 8 deletions(-)
> create mode 100644 drivers/amba/Kconfig
>
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 052fba07a3cb..fae2eb2f52ea 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -64,12 +64,4 @@ config ARCH_TEGRA_124_SOC
> Support for NVIDIA Tegra T124 processor family, based on the
> ARM CortexA15MP CPU
>
> -config TEGRA_AHB
> - bool "Enable AHB driver for NVIDIA Tegra SoCs"
> - default y
> - help
> - Adds AHB configuration functionality for NVIDIA Tegra SoCs,
> - which controls AHB bus master arbitration and some
> - performance parameters(priority, prefech size).
> -
> endif
> diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig
> new file mode 100644
> index 000000000000..3f7350a03708
> --- /dev/null
> +++ b/drivers/amba/Kconfig
> @@ -0,0 +1,11 @@
> +if ARM_AMBA
> +
> +config TEGRA_AHB
> + bool "Enable AHB driver for NVIDIA Tegra SoCs"
> + default y if ARCH_TEGRA
> + help
> + Adds AHB configuration functionality for NVIDIA Tegra SoCs,
> + which controls AHB bus master arbitration and some performance
> + parameters (priority, prefetch size).
> +
> +endif
>

2014-10-02 10:51:11

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: Move AHB Kconfig to drivers/amba

On Thu, Sep 04, 2014 at 01:37:27PM -0600, Stephen Warren wrote:
> On 08/25/2014 11:29 AM, Stephen Warren wrote:
> >On 07/29/2014 10:21 AM, Stephen Warren wrote:
> >>On 07/29/2014 08:25 AM, Thierry Reding wrote:
> >>>From: Thierry Reding <[email protected]>
> >>>
> >>>This will allow the Kconfig option to be shared among 32-bit and 64-bit
> >>>ARM.
> >>
> >>This seems fine to me. I'd expect to apply it for 3.18, provided I get
> >>an ack from Russell as drivers/amba maintainer (hence CCing him without
> >>trimming the quote).
> >
> >Russell,
> >
> >Are you OK with this patch? If so, if you could ack it so I can apply
> >it, that would be great.
>
> Russell?

Russell,

Can I have your Acked-by on this or would you prefer it to be submitted
to the patch tracker? Would the patch tracker be the correct place also
for non-ARM core patches?

Thierry


Attachments:
(No filename) (857.00 B)
(No filename) (819.00 B)
Download all attachments

2014-10-02 11:08:17

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: Move AHB Kconfig to drivers/amba

On Thu, Oct 02, 2014 at 12:51:04PM +0200, Thierry Reding wrote:
> On Thu, Sep 04, 2014 at 01:37:27PM -0600, Stephen Warren wrote:
> > On 08/25/2014 11:29 AM, Stephen Warren wrote:
> > >On 07/29/2014 10:21 AM, Stephen Warren wrote:
> > >>On 07/29/2014 08:25 AM, Thierry Reding wrote:
> > >>>From: Thierry Reding <[email protected]>
> > >>>
> > >>>This will allow the Kconfig option to be shared among 32-bit and 64-bit
> > >>>ARM.
> > >>
> > >>This seems fine to me. I'd expect to apply it for 3.18, provided I get
> > >>an ack from Russell as drivers/amba maintainer (hence CCing him without
> > >>trimming the quote).
> > >
> > >Russell,
> > >
> > >Are you OK with this patch? If so, if you could ack it so I can apply
> > >it, that would be great.
> >
> > Russell?
>
> Russell,
>
> Can I have your Acked-by on this or would you prefer it to be submitted
> to the patch tracker? Would the patch tracker be the correct place also
> for non-ARM core patches?

I just had to go digging for the original patch, as I've been missing
this.

I think this is fine, though if we're going to have drivers/amba/Kconfig,
we should also move the ARM_AMBA Kconfig option there too. Note that it
currently appears in both arch/arm/Kconfig and arch/arm64/Kconfig.

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

2014-10-02 12:54:56

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: Move AHB Kconfig to drivers/amba

On Thu, Oct 02, 2014 at 12:08:05PM +0100, Russell King - ARM Linux wrote:
> On Thu, Oct 02, 2014 at 12:51:04PM +0200, Thierry Reding wrote:
> > On Thu, Sep 04, 2014 at 01:37:27PM -0600, Stephen Warren wrote:
> > > On 08/25/2014 11:29 AM, Stephen Warren wrote:
> > > >On 07/29/2014 10:21 AM, Stephen Warren wrote:
> > > >>On 07/29/2014 08:25 AM, Thierry Reding wrote:
> > > >>>From: Thierry Reding <[email protected]>
> > > >>>
> > > >>>This will allow the Kconfig option to be shared among 32-bit and 64-bit
> > > >>>ARM.
> > > >>
> > > >>This seems fine to me. I'd expect to apply it for 3.18, provided I get
> > > >>an ack from Russell as drivers/amba maintainer (hence CCing him without
> > > >>trimming the quote).
> > > >
> > > >Russell,
> > > >
> > > >Are you OK with this patch? If so, if you could ack it so I can apply
> > > >it, that would be great.
> > >
> > > Russell?
> >
> > Russell,
> >
> > Can I have your Acked-by on this or would you prefer it to be submitted
> > to the patch tracker? Would the patch tracker be the correct place also
> > for non-ARM core patches?
>
> I just had to go digging for the original patch, as I've been missing
> this.
>
> I think this is fine, though if we're going to have drivers/amba/Kconfig,
> we should also move the ARM_AMBA Kconfig option there too. Note that it
> currently appears in both arch/arm/Kconfig and arch/arm64/Kconfig.

Okay, let me turn that into a prequel patch for this one.

Thierry


Attachments:
(No filename) (1.43 kB)
(No filename) (819.00 B)
Download all attachments