2014-10-01 23:06:58

by Luis Henriques

Subject: [PATCH] acct: fix build warning when ACCT_VERSION != 3

struct pid_namespace *ns is used only when ACCT_VERSION is 3.

kernel/acct.c:475:24: warning: unused variable 'ns' [-Wunused-variable]

Signed-off-by: Luis Henriques <[email protected]>
---
kernel/acct.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/kernel/acct.c b/kernel/acct.c
index b4c667d22e79..5f277f5c5e29 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -472,7 +472,9 @@ static void do_acct_process(struct bsd_acct_struct *acct)
acct_t ac;
unsigned long flim;
const struct cred *orig_cred;
+#if ACCT_VERSION == 3
struct pid_namespace *ns = acct->ns;
+#endif
struct file *file = acct->file;

/*
--
2.1.0

2014-10-02 21:09:47

by Andrew Morton

Subject: Re: [PATCH] acct: fix build warning when ACCT_VERSION != 3

On Thu, 2 Oct 2014 00:06:53 +0100 Luis Henriques <[email protected]> wrote:

> struct pid_namespace *ns is used only when ACCT_VERSION is 3.
>
> kernel/acct.c:475:24: warning: unused variable 'ns' [-Wunused-variable]
>
> Signed-off-by: Luis Henriques <[email protected]>
> ---
> kernel/acct.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index b4c667d22e79..5f277f5c5e29 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -472,7 +472,9 @@ static void do_acct_process(struct bsd_acct_struct *acct)
> acct_t ac;
> unsigned long flim;
> const struct cred *orig_cred;
> +#if ACCT_VERSION == 3
> struct pid_namespace *ns = acct->ns;
> +#endif
> struct file *file = acct->file;
>
> /*

It's always a good idea to check linux-next. This has been addressed by
http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning.patch
http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning-fix.patch

2014-10-02 21:55:36

by Luis Henriques

Subject: Re: [PATCH] acct: fix build warning when ACCT_VERSION != 3

On Thu, Oct 02, 2014 at 02:09:45PM -0700, Andrew Morton wrote:
> On Thu, 2 Oct 2014 00:06:53 +0100 Luis Henriques <[email protected]> wrote:
>
> > struct pid_namespace *ns is used only when ACCT_VERSION is 3.
> >
> > kernel/acct.c:475:24: warning: unused variable 'ns' [-Wunused-variable]
> >
> > Signed-off-by: Luis Henriques <[email protected]>
> > ---
> > kernel/acct.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/kernel/acct.c b/kernel/acct.c
> > index b4c667d22e79..5f277f5c5e29 100644
> > --- a/kernel/acct.c
> > +++ b/kernel/acct.c
> > @@ -472,7 +472,9 @@ static void do_acct_process(struct bsd_acct_struct *acct)
> > acct_t ac;
> > unsigned long flim;
> > const struct cred *orig_cred;
> > +#if ACCT_VERSION == 3
> > struct pid_namespace *ns = acct->ns;
> > +#endif
> > struct file *file = acct->file;
> >
> > /*
>
> It's always a good idea to check linux-next. This has been addressed by
> http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning.patch
> http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning-fix.patch
>
>

Ah, awesome! I missed these patches. Thanks Andrew.

Cheers,
--
Lu?s