2014-10-02 14:08:22

by Chen Gang

Subject: [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM

NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
allmodconfig under um):

CC [M] drivers/net/dsa/bcm_sf2.o
drivers/net/dsa/bcm_sf2.c: In function ‘bcm_sf2_sw_setup’:
drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(*base);
^

Signed-off-by: Chen Gang <[email protected]>
---
drivers/net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index ea0697e..9234d80 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -47,6 +47,7 @@ config NET_DSA_MV88E6171

config NET_DSA_BCM_SF2
tristate "Broadcom Starfighter 2 Ethernet switch support"
+ depends on HAS_IOMEM
select NET_DSA
select NET_DSA_TAG_BRCM
select FIXED_PHY if NET_DSA_BCM_SF2=y
--
1.9.3

2014-10-02 16:44:28

by Florian Fainelli

Subject: Re: [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM

On 10/02/2014 07:14 AM, Chen Gang wrote:
> NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> CC [M] drivers/net/dsa/bcm_sf2.o
> drivers/net/dsa/bcm_sf2.c: In function ‘bcm_sf2_sw_setup’:
> drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(*base);
> ^
>
> Signed-off-by: Chen Gang <[email protected]>

Acked-by: Florian Fainelli <[email protected]>

> ---
> drivers/net/dsa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
> index ea0697e..9234d80 100644
> --- a/drivers/net/dsa/Kconfig
> +++ b/drivers/net/dsa/Kconfig
> @@ -47,6 +47,7 @@ config NET_DSA_MV88E6171
>
> config NET_DSA_BCM_SF2
> tristate "Broadcom Starfighter 2 Ethernet switch support"
> + depends on HAS_IOMEM
> select NET_DSA
> select NET_DSA_TAG_BRCM
> select FIXED_PHY if NET_DSA_BCM_SF2=y
>

2014-10-03 22:50:37

by David Miller

Subject: Re: [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM

From: Chen Gang <[email protected]>
Date: Thu, 02 Oct 2014 22:14:04 +0800

> NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> CC [M] drivers/net/dsa/bcm_sf2.o
> drivers/net/dsa/bcm_sf2.c: In function ?bcm_sf2_sw_setup?:
> drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ?iounmap? [-Werror=implicit-function-declaration]
> iounmap(*base);
> ^
>
> Signed-off-by: Chen Gang <[email protected]>

Applied.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?