2014-10-05 17:48:13

by Borislav Petkov

[permalink] [raw]
Subject: Re: perf & rasd integration plan

Top-posting on purpose:

Btw, jolsa, if you get your LCE proposal for the perf splitting
approved, please post the time here so people can come.

Thanks.

On Tue, Sep 30, 2014 at 10:24:16AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 30, 2014 at 11:06:21AM +0200, Jean Pihet escreveu:
> > The RAS Deamon (rasd) as available at [1] and the development version
> > at [2], allows to enable kernel tracepoints and outputs the
> > tracepoints fields according to the kernel format.
> >
> > [1] https://git.kernel.org/cgit/utils/ras/rasd.git/
> > [2] https://git.linaro.org/people/jean.pihet/rasd.git
> >
> > rasd currently is a duplicate of the perf tool code, ultimately perf
> > and rasd will use the same common code. The goal is to factor out the
> > common code from perf and place it in small librairies in tools/lib.
> >
> > Here is the code that rasd currently uses and that should be moved to tools/lib:
> >
> > - debugfs: already in tools/lib/api/fs
> > . mount and retrieve path
> >
> > - evlist: tools/perf/util/evlist.[ch]
> > . create and init new evlist,
> > . set cpu and thread maps,
> > . add events to evlist,
> > . init and use internal event id,
> > . alloc and mmap events buffers, manage file descriptors,
> > . enable events,
> > . read events buffers, parse data,
> > . unmap and free buffers
> >
> > - evsel: tools/perf/util/evsel.[ch]
> > . create and init new tracepoints events,
> > . init and use internal event id,
> > . open events, manage fds,
> > . close and free events
> >
> > - trace-event: tools/perf/util/trace-event.[ch] and
> > tools/perf/util/trace-event-parse.c
> > . retrieve and parse events format (using event-parse),
> > . print out events fields
> >
> > - event-parse: already in tools/lib/traceevent/event-parse.[ch]
> > . retrieve and parse events format,
> > . parse events format and print out events fields
> >
> > - trace-seq: already in tools/lib/traceevent/trace-seq.c
> > . format output string for event fields
> >
> > - events plugins: already in tools/lib/traceevent/event-plugin.c
> >
> > - util: tools/perf/util/util.[ch]
> > . files open/read,
> > . manage events attributes,
> > . various macros
> >
> > - test events attributes: tools/perf/tests/attr.c
> > . test_attr__open()
> >
> > - thread: tools/perf/util/thread_map.[ch] and
> > - cpu: tools/perf/util/cpumap.[ch]
> > . init and manage process maps
> >
> > - xyarray: tools/perf/util/xyarray.[ch]
> >
> > - syscall: tools/perf/perf-sys.h
> >
> > - cgroup: tools/perf/util/cgroup.[ch]
> >
> > The plan is to move the small and generic functions first: util,
> > xyarray, cpumap, thread_map etc; then evlist, evsel, trace-event,
> > trace-event-parse; and finally integrate rasd into the tools/ dir.
> >
> > Any thought? Can evlist, evsel etc. be moved at once?
> >
> > Patches should come soon, when time allows.
>
> Why don't you add it to tools/rasd/ and in tools/rasd/Makefile you just
> go on and add tools/perf/util/evlist.o et all to be linked directly, as
> a first step.
>
> Then, as a second step, we can create a tools/lib/perf/evlist.c having
> what is currently used by both tools/perf/ and tools/rasd/, i.e. what is
> proven to be useful for something other than perf.
>
> As the need arises, we go on moving things into tools/lib/perf/evlist.c
> et all from wherever it appeared first, be it from tools/rasd/,
> tools/perf/util/evlist.c or anywhere else.
>
> Initial rule being that once it is used by multiple tools living in
> tools/, then it deserves a place in tools/lib/perf/.
>
> Ditto for other stuff currently living in tools/perf/util/.
>
> - Arnaldo
>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


2014-10-05 18:25:11

by Jiri Olsa

[permalink] [raw]
Subject: Re: perf & rasd integration plan

On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
> Top-posting on purpose:
>
> Btw, jolsa, if you get your LCE proposal for the perf splitting
> approved, please post the time here so people can come.

yep, it got accepted, ther schedule is:
Friday, October 17, 2014 from 9:00am – Noon
Room 2

https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351

jirka

2014-10-05 18:45:22

by Borislav Petkov

[permalink] [raw]
Subject: Re: perf & rasd integration plan

On Sun, Oct 05, 2014 at 08:24:42PM +0200, Jiri Olsa wrote:
> On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
> > Top-posting on purpose:
> >
> > Btw, jolsa, if you get your LCE proposal for the perf splitting
> > approved, please post the time here so people can come.
>
> yep, it got accepted, ther schedule is:
> Friday, October 17, 2014 from 9:00am – Noon
> Room 2
>
> https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351

Cool, thanks.

I'll add it to the calendar - lot to do this conf :-)

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

2014-10-05 19:24:09

by Chuck Ebbert

[permalink] [raw]
Subject: Re: perf & rasd integration plan

On Sun, 5 Oct 2014 20:24:42 +0200
Jiri Olsa <[email protected]> wrote:

> On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
> > Top-posting on purpose:
> >
> > Btw, jolsa, if you get your LCE proposal for the perf splitting
> > approved, please post the time here so people can come.
>
> yep, it got accepted, ther schedule is:
> Friday, October 17, 2014 from 9:00am – Noon
> Room 2
>
> https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351
>

The SSL cert for that site is comic.

1. Expired over three years ago.

2. Was issued to a different domain.

3. Issued by an un-verifiable CA.

This is a joke, right?

2014-10-05 19:29:25

by Jiri Olsa

[permalink] [raw]
Subject: Re: perf & rasd integration plan

On Sun, Oct 05, 2014 at 02:24:01PM -0500, Chuck Ebbert wrote:
> On Sun, 5 Oct 2014 20:24:42 +0200
> Jiri Olsa <[email protected]> wrote:
>
> > On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
> > > Top-posting on purpose:
> > >
> > > Btw, jolsa, if you get your LCE proposal for the perf splitting
> > > approved, please post the time here so people can come.
> >
> > yep, it got accepted, ther schedule is:
> > Friday, October 17, 2014 from 9:00am – Noon
> > Room 2
> >
> > https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351
> >
>
> The SSL cert for that site is comic.
>
> 1. Expired over three years ago.
>
> 2. Was issued to a different domain.
>
> 3. Issued by an un-verifiable CA.
>
> This is a joke, right?

;-) it's the link from this page:
http://www.linuxplumbersconf.org/2014/ocw/events/LPC2014/schedule

jirka

2014-10-06 06:53:55

by Jean Pihet

[permalink] [raw]
Subject: Re: perf & rasd integration plan

Hi Jiri,


On 5 October 2014 20:24, Jiri Olsa <[email protected]> wrote:
> On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
>> Top-posting on purpose:
>>
>> Btw, jolsa, if you get your LCE proposal for the perf splitting
>> approved, please post the time here so people can come.
>
> yep, it got accepted, ther schedule is:
> Friday, October 17, 2014 from 9:00am – Noon
> Room 2
>
> https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351
Great! Are there slides that we can download?

I have a couple of weeks to work on this, I can prepare the first set
of patches.

Note: I will not be at ELCE/LPC but could attend remotely or have a
call to discuss the points.

Cheers,
Jean

>
> jirka

2014-10-08 06:59:56

by Jiri Olsa

[permalink] [raw]
Subject: Re: perf & rasd integration plan

On Mon, Oct 06, 2014 at 08:53:51AM +0200, Jean Pihet wrote:
> Hi Jiri,
>
>
> On 5 October 2014 20:24, Jiri Olsa <[email protected]> wrote:
> > On Sun, Oct 05, 2014 at 07:48:01PM +0200, Borislav Petkov wrote:
> >> Top-posting on purpose:
> >>
> >> Btw, jolsa, if you get your LCE proposal for the perf splitting
> >> approved, please post the time here so people can come.
> >
> > yep, it got accepted, ther schedule is:
> > Friday, October 17, 2014 from 9:00am – Noon
> > Room 2
> >
> > https://pdxplumbers.osuosl.org/2014/ocw/events/LPC2014/tracks/351
> Great! Are there slides that we can download?

there'll be just one.. I'm on vacation this week,
so I'll try send some till end of the week

jirka