2014-10-08 19:19:08

by Nicolas Dechesne

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform

Georgi,

On Tue, Sep 2, 2014 at 5:40 PM, Georgi Djakov <[email protected]> wrote:
> Enable support for the two SD host controllers on the APQ8084 platform
> by adding the required nodes to the DT files.
> On the IFC6540 board, the first controller is connected to the onboard
> eMMC and the second is connected to a micro-SD card slot.

testing this set of patch on IFC6540, i noticed that not all
partitions from the eMMC are detected. booting [1] which is basically
3.17-rc7 with a few additional patches, i can see the following
relevant mmc traces:

[ 1.162587] mmc0: BKOPS_EN bit is not set
[ 1.315357] mmc0: new HS200 MMC card at address 0001
[ 1.318098] mmcblk0: mmc0:0001 SEM16G 14.6 GiB
[ 1.330377] mmcblk0boot0: mmc0:0001 SEM16G partition 1 4.00 MiB
[ 1.333652] mmcblk0boot1: mmc0:0001 SEM16G partition 2 4.00 MiB
[ 1.345424] mmcblk0rpmb: mmc0:0001 SEM16G partition 3 4.00 MiB
[ 1.358135] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15
[ 1.365902] mmcblk0boot1: p1
[ 1.367833] mmcblk0boot0: unknown partition table

on the same board, booting the board vendor kernel (which is based on
QCOM 3.10 tree), i can see much more partitions:

[ 7.662379] mmc0: BKOPS_EN bit = 0
[ 7.673036] mmc0: new HS200 MMC card at address 0001
[ 7.673784] mmcblk0: mmc0:0001 SEM16G 14.6 GiB
[ 7.674311] mmcblk0rpmb: mmc0:0001 SEM16G partition 3 4.00 MiB
[ 7.677967] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13
p14 p15 p16 p17 p18 p19 p20 p21 p22 p23 p24\
p25

the complete dmesg log for can be found in our board lab, at [2]

cheers

[1] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/b538bdefecd11bd0278cc31164e1078c1722e5a8
[2] http://armv7.com/scheduler/job/11726/log_file#L_11_11


2014-10-08 19:51:36

by Josh Cartwright

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform

On Wed, Oct 08, 2014 at 09:18:44PM +0200, Nicolas Dechesne wrote:
> Georgi,
>
> On Tue, Sep 2, 2014 at 5:40 PM, Georgi Djakov <[email protected]> wrote:
> > Enable support for the two SD host controllers on the APQ8084 platform
> > by adding the required nodes to the DT files.
> > On the IFC6540 board, the first controller is connected to the onboard
> > eMMC and the second is connected to a micro-SD card slot.
>
> testing this set of patch on IFC6540, i noticed that not all
> partitions from the eMMC are detected. booting [1] which is basically
> 3.17-rc7 with a few additional patches, i can see the following
> relevant mmc traces:
>
> [ 1.162587] mmc0: BKOPS_EN bit is not set
> [ 1.315357] mmc0: new HS200 MMC card at address 0001
> [ 1.318098] mmcblk0: mmc0:0001 SEM16G 14.6 GiB
> [ 1.330377] mmcblk0boot0: mmc0:0001 SEM16G partition 1 4.00 MiB
> [ 1.333652] mmcblk0boot1: mmc0:0001 SEM16G partition 2 4.00 MiB
> [ 1.345424] mmcblk0rpmb: mmc0:0001 SEM16G partition 3 4.00 MiB
> [ 1.358135] mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15
> [ 1.365902] mmcblk0boot1: p1
> [ 1.367833] mmcblk0boot0: unknown partition table

This has bitten me more times than I care to admit, but have you checked
that you've set CONFIG_MMC_BLOCK_MINORS higher than 16? Perhaps we
should be doing that in qcom_defconfig if we aren't already.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

2014-10-09 06:57:09

by Nicolas Dechesne

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform

On Wed, Oct 8, 2014 at 9:45 PM, Josh Cartwright <[email protected]> wrote:
> This has bitten me more times than I care to admit, but have you checked
> that you've set CONFIG_MMC_BLOCK_MINORS higher than 16? Perhaps we
> should be doing that in qcom_defconfig if we aren't already.

ouch... i was using multi_v7_defconfig which indeed has:

CONFIG_MMC_BLOCK_MINORS=16

note that you can override the default CONFIG with bootargs with

mmcblk.perdev_minors=32

thanks!