2014-10-14 17:01:22

by Fabian Frédérick

Subject: [PATCH V2 2/2 net-next] caif_usb: use target structure member in memset

parent cfusbl was used instead of first structure member 'layer'

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
net/caif/caif_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index 0e487b0..5cd44f0 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -92,7 +92,7 @@ static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],

caif_assert(offsetof(struct cfusbl, layer) == 0);

- memset(this, 0, sizeof(struct cflayer));
+ memset(&this->layer, 0, sizeof(this->layer));
this->layer.receive = cfusbl_receive;
this->layer.transmit = cfusbl_transmit;
this->layer.ctrlcmd = cfusbl_ctrlcmd;
--
1.9.3

2014-10-14 20:06:09

by David Miller

Subject: Re: [PATCH V2 2/2 net-next] caif_usb: use target structure member in memset

From: Fabian Frederick <[email protected]>
Date: Tue, 14 Oct 2014 19:01:14 +0200

> parent cfusbl was used instead of first structure member 'layer'
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied.