2014-10-14 14:13:49

by Josh Boyer

Subject: [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch

This driver is only usable on 64-bit s390 machines. Mark the Kconfig
dependencies to that users on other architectures are not prompted for it.

Fixes: 8f933b1043e1e5 ("s390/hmcdrv: HMC drive CD/DVD access")
Signed-off-by: Josh Boyer <[email protected]>
---
drivers/s390/char/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
index dc24ecfac2d1..db2cb1f8a1b5 100644
--- a/drivers/s390/char/Kconfig
+++ b/drivers/s390/char/Kconfig
@@ -105,7 +105,7 @@ config SCLP_ASYNC
config HMC_DRV
def_tristate m
prompt "Support for file transfers from HMC drive CD/DVD-ROM"
- depends on 64BIT
+ depends on S390 && 64BIT
select CRC16
help
This option enables support for file transfers from a Hardware
--
1.9.3

2014-10-14 15:03:40

by Martin Schwidefsky

Subject: Re: [PATCH] s390/hmcdrv: Restrict s390 HMC driver to S390 arch

On Tue, 14 Oct 2014 10:13:42 -0400
Josh Boyer <[email protected]> wrote:

> This driver is only usable on 64-bit s390 machines. Mark the Kconfig
> dependencies to that users on other architectures are not prompted for it.
>
> Fixes: 8f933b1043e1e5 ("s390/hmcdrv: HMC drive CD/DVD access")
> Signed-off-by: Josh Boyer <[email protected]>
> ---
> drivers/s390/char/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index dc24ecfac2d1..db2cb1f8a1b5 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -105,7 +105,7 @@ config SCLP_ASYNC
> config HMC_DRV
> def_tristate m
> prompt "Support for file transfers from HMC drive CD/DVD-ROM"
> - depends on 64BIT
> + depends on S390 && 64BIT
> select CRC16
> help
> This option enables support for file transfers from a Hardware

Indeed. I'll queue this patch to the fixes branch of the s390 tree.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.