2014-10-20 09:18:01

by Paul Bolle

[permalink] [raw]
Subject: [PATCH] virtio: Fix comment typo 'CONFIG_S_FAILED'

Without the VIRTIO_ prefix CONFIG_S_FAILED looks like a Kconfig macro.
So use that prefix here too.

Signed-off-by: Paul Bolle <[email protected]>
---
Introduced in commit c6716bae52f9 ("virtio-pci: move freeze/restore to
virtio core").

Tested with "git grep" only.

include/linux/virtio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 65261a7244fc..abafae783058 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -78,7 +78,7 @@ bool virtqueue_is_broken(struct virtqueue *vq);
/**
* virtio_device - representation of a device using virtio
* @index: unique position on the virtio bus
- * @failed: saved value for CONFIG_S_FAILED bit (for restore)
+ * @failed: saved value for VIRTIO_CONFIG_S_FAILED bit (for restore)
* @config_enabled: configuration change reporting enabled
* @config_change_pending: configuration change reported while disabled
* @config_lock: protects configuration change reporting
--
1.9.3


2014-10-20 10:29:12

by Cornelia Huck

[permalink] [raw]
Subject: Re: [PATCH] virtio: Fix comment typo 'CONFIG_S_FAILED'

On Mon, 20 Oct 2014 11:17:56 +0200
Paul Bolle <[email protected]> wrote:

> Without the VIRTIO_ prefix CONFIG_S_FAILED looks like a Kconfig macro.
> So use that prefix here too.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Introduced in commit c6716bae52f9 ("virtio-pci: move freeze/restore to
> virtio core").
>
> Tested with "git grep" only.
>
> include/linux/virtio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Cornelia Huck <[email protected]>

2014-10-31 00:39:29

by Rusty Russell

[permalink] [raw]
Subject: Re: [PATCH] virtio: Fix comment typo 'CONFIG_S_FAILED'

Cornelia Huck <[email protected]> writes:
> On Mon, 20 Oct 2014 11:17:56 +0200
> Paul Bolle <[email protected]> wrote:
>
>> Without the VIRTIO_ prefix CONFIG_S_FAILED looks like a Kconfig macro.
>> So use that prefix here too.
>>
>> Signed-off-by: Paul Bolle <[email protected]>
>> ---
>> Introduced in commit c6716bae52f9 ("virtio-pci: move freeze/restore to
>> virtio core").
>>
>> Tested with "git grep" only.
>>
>> include/linux/virtio.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Cornelia Huck <[email protected]>

Applied.

Thanks!
Rusty.