(resending to new documentation maintainer, as the original patch
seemingly got lost)
Jonathan,
Please apply the below patch documenting that hugetlbfs can be sticky-mounted.
Thanks beforehand,
Kirill
On Thu, Sep 04, 2014 at 10:14:31AM -0700, Ken Chen wrote:
> On Thu, Sep 4, 2014 at 6:20 AM, Kirill Smelkov <[email protected]> wrote:
> > Commit 75897d60 (hugetlb: allow sticky directory mount option) added
> > support for mounting hugetlbfs with sticky option set, like /tmp is
> > usually mounted, but forgot to document that.
> >
> > Cc: Ken Chen <[email protected]>
> > Signed-off-by: Kirill Smelkov <[email protected]>
> > ---
> > Documentation/vm/hugetlbpage.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/vm/hugetlbpage.txt b/Documentation/vm/hugetlbpage.txt
> > index bdd4bb9..b64e0af 100644
> > --- a/Documentation/vm/hugetlbpage.txt
> > +++ b/Documentation/vm/hugetlbpage.txt
> > @@ -274,7 +274,7 @@ This command mounts a (pseudo) filesystem of type hugetlbfs on the directory
> > /mnt/huge. Any files created on /mnt/huge uses huge pages. The uid and gid
> > options sets the owner and group of the root of the file system. By default
> > the uid and gid of the current process are taken. The mode option sets the
> > -mode of root of file system to value & 0777. This value is given in octal.
> > +mode of root of file system to value & 01777. This value is given in octal.
> > By default the value 0755 is picked. The size option sets the maximum value of
> > memory (huge pages) allowed for that filesystem (/mnt/huge). The size is
> > rounded down to HPAGE_SIZE. The option nr_inodes sets the maximum number of
>
> Acked-by: Ken Chen <[email protected]>
---- 8< ----
From: Kirill Smelkov <[email protected]>
Date: Thu, 4 Sep 2014 17:13:00 +0400
Subject: [PATCH] hugetlbfs: document that sticky mounts are allowed
Commit 75897d60 (hugetlb: allow sticky directory mount option) added
support for mounting hugetlbfs with sticky option set, like /tmp is
usually mounted, but forgot to document that.
Cc: Ken Chen <[email protected]>
Signed-off-by: Kirill Smelkov <[email protected]>
Acked-by: Ken Chen <[email protected]>
---
Documentation/vm/hugetlbpage.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/vm/hugetlbpage.txt b/Documentation/vm/hugetlbpage.txt
index bdd4bb9..b64e0af 100644
--- a/Documentation/vm/hugetlbpage.txt
+++ b/Documentation/vm/hugetlbpage.txt
@@ -274,7 +274,7 @@ This command mounts a (pseudo) filesystem of type hugetlbfs on the directory
/mnt/huge. Any files created on /mnt/huge uses huge pages. The uid and gid
options sets the owner and group of the root of the file system. By default
the uid and gid of the current process are taken. The mode option sets the
-mode of root of file system to value & 0777. This value is given in octal.
+mode of root of file system to value & 01777. This value is given in octal.
By default the value 0755 is picked. The size option sets the maximum value of
memory (huge pages) allowed for that filesystem (/mnt/huge). The size is
rounded down to HPAGE_SIZE. The option nr_inodes sets the maximum number of
--
2.1.0.61.g11be0d6
On Wed, 22 Oct 2014 19:54:46 +0400
Kirill Smelkov <[email protected]> wrote:
> Please apply the below patch documenting that hugetlbfs can be sticky-mounted.
It documents it in a rather obscure way...but, then, to be clear, that
document needs a lot of help in general.
Applied. Redundant Cc tag removed.
Thanks,
jon
On Wed, Oct 22, 2014 at 02:28:26PM -0400, Jonathan Corbet wrote:
> On Wed, 22 Oct 2014 19:54:46 +0400
> Kirill Smelkov <[email protected]> wrote:
>
> > Please apply the below patch documenting that hugetlbfs can be sticky-mounted.
>
> It documents it in a rather obscure way...but, then, to be clear, that
> document needs a lot of help in general.
I agree the documentation is a bit obscure and it was not a proper fix,
but "let's at least restore consistency between .txt & .c"
> Applied. Redundant Cc tag removed.
Thanks,
Kirill