2014-10-27 18:03:31

by Fabian Frédérick

Subject: [PATCH 1/1] ipv4: remove set but unused variable sha

unsigned char *sha (source) was already in original git version
but was never used.

Signed-off-by: Fabian Frederick <[email protected]>
---
net/ipv4/ipconfig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 648fa14..a896da5 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -498,7 +498,7 @@ ic_rarp_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
struct arphdr *rarp;
unsigned char *rarp_ptr;
__be32 sip, tip;
- unsigned char *sha, *tha; /* s for "source", t for "target" */
+ unsigned char *tha; /* t for "target" */
struct ic_device *d;

if (!net_eq(dev_net(dev), &init_net))
@@ -549,7 +549,6 @@ ic_rarp_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
goto drop_unlock; /* should never happen */

/* Extract variable-width fields */
- sha = rarp_ptr;
rarp_ptr += dev->addr_len;
memcpy(&sip, rarp_ptr, 4);
rarp_ptr += 4;
--
1.9.1

2014-10-27 20:04:26

by David Miller

Subject: Re: [PATCH 1/1] ipv4: remove set but unused variable sha

From: Fabian Frederick <[email protected]>
Date: Mon, 27 Oct 2014 19:03:22 +0100

> unsigned char *sha (source) was already in original git version
> but was never used.
>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied.