2014-10-31 22:02:11

by Mariusz Gorski

Subject: [PATCH v3] staging: panel: Remove outdated TODO tasks

Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.

Signed-off-by: Mariusz Gorski <[email protected]>
---
v3: Fixed commit summary

drivers/staging/panel/TODO | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
index a4be749..c8040c1 100644
--- a/drivers/staging/panel/TODO
+++ b/drivers/staging/panel/TODO
@@ -1,6 +1,4 @@
TODO:
- - checkpatch.pl cleanups
- - Lindent
- review major/minor usages
- review userspace api
- see if all of this could be easier done in userspace instead.
--
2.1.3

2014-10-31 22:08:41

by Konrad Zapalowicz

Subject: Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
>
> Signed-off-by: Mariusz Gorski <[email protected]>
> ---
> v3: Fixed commit summary

Great. Thanks.

regards,
konrad

> drivers/staging/panel/TODO | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> index a4be749..c8040c1 100644
> --- a/drivers/staging/panel/TODO
> +++ b/drivers/staging/panel/TODO
> @@ -1,6 +1,4 @@
> TODO:
> - - checkpatch.pl cleanups
> - - Lindent
> - review major/minor usages
> - review userspace api
> - see if all of this could be easier done in userspace instead.
> --
> 2.1.3
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

2014-11-01 04:59:25

by Sudip Mukherjee

Subject: Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
> On 10/31, Mariusz Gorski wrote:
> > Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> > is obsolete and the other one is already done.
> >

when i checked panel.c with checkpatch and with --strict option, i got 20 checks.
(sent the same reply to v1 patch also).

thanks
sudip

> > Signed-off-by: Mariusz Gorski <[email protected]>
> > ---
> > v3: Fixed commit summary
>
> Great. Thanks.
>
> regards,
> konrad
>
> > drivers/staging/panel/TODO | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> > index a4be749..c8040c1 100644
> > --- a/drivers/staging/panel/TODO
> > +++ b/drivers/staging/panel/TODO
> > @@ -1,6 +1,4 @@
> > TODO:
> > - - checkpatch.pl cleanups
> > - - Lindent
> > - review major/minor usages
> > - review userspace api
> > - see if all of this could be easier done in userspace instead.
> > --
> > 2.1.3
> >
> > _______________________________________________
> > devel mailing list
> > [email protected]
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2014-11-01 10:50:48

by Mariusz Gorski

Subject: Re: [PATCH v3] staging: panel: Remove outdated TODO tasks

On Sat, Nov 01, 2014 at 10:29:16AM +0530, Sudip Mukherjee wrote:
> On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
> > On 10/31, Mariusz Gorski wrote:
> > > Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> > > is obsolete and the other one is already done.
> > >
>
> when i checked panel.c with checkpatch and with --strict option, i got 20 checks.
> (sent the same reply to v1 patch also).

Good point, supid. Thanks! I guess the checkpatch.pl issues deserve a
separate patch, so I'll just reduce the scope of this one.

Cheers,
Mariusz

> thanks
> sudip
>
> > > Signed-off-by: Mariusz Gorski <[email protected]>
> > > ---
> > > v3: Fixed commit summary
> >
> > Great. Thanks.
> >
> > regards,
> > konrad
> >
> > > drivers/staging/panel/TODO | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
> > > index a4be749..c8040c1 100644
> > > --- a/drivers/staging/panel/TODO
> > > +++ b/drivers/staging/panel/TODO
> > > @@ -1,6 +1,4 @@
> > > TODO:
> > > - - checkpatch.pl cleanups
> > > - - Lindent
> > > - review major/minor usages
> > > - review userspace api
> > > - see if all of this could be easier done in userspace instead.
> > > --
> > > 2.1.3
> > >
> > > _______________________________________________
> > > devel mailing list
> > > [email protected]
> > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/