2014-11-03 18:15:20

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH v2 2/5] video: add RGB444_1X12 and RGB565_1X16 bus formats

Em Mon, 29 Sep 2014 16:02:40 +0200
Boris Brezillon <[email protected]> escreveu:

> Add RGB444 format using a 12 bits bus and RGB565 using a 16 bits bus.
>
> These formats will later be used by atmel-hlcdc driver.
>
> Signed-off-by: Boris BREZILLON <[email protected]>

Not sure if it is too late, but this patch were hidden somewere on my
queue... so:

Acked-by: Mauro Carvalho Chehab <[email protected]>

> ---
> include/uapi/linux/v4l2-mediabus.h | 2 ++
> include/uapi/linux/video-bus-format.h | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/v4l2-mediabus.h b/include/uapi/linux/v4l2-mediabus.h
> index 7b0a06c..05336d6 100644
> --- a/include/uapi/linux/v4l2-mediabus.h
> +++ b/include/uapi/linux/v4l2-mediabus.h
> @@ -33,6 +33,8 @@ enum v4l2_mbus_pixelcode {
> VIDEO_BUS_TO_V4L2_MBUS(RGB888_2X12_BE),
> VIDEO_BUS_TO_V4L2_MBUS(RGB888_2X12_LE),
> VIDEO_BUS_TO_V4L2_MBUS(ARGB8888_1X32),
> + VIDEO_BUS_TO_V4L2_MBUS(RGB444_1X12),
> + VIDEO_BUS_TO_V4L2_MBUS(RGB565_1X16),
>
> VIDEO_BUS_TO_V4L2_MBUS(Y8_1X8),
> VIDEO_BUS_TO_V4L2_MBUS(UV8_1X8),
> diff --git a/include/uapi/linux/video-bus-format.h b/include/uapi/linux/video-bus-format.h
> index 4abbd5d..f85f7ee 100644
> --- a/include/uapi/linux/video-bus-format.h
> +++ b/include/uapi/linux/video-bus-format.h
> @@ -34,7 +34,7 @@
> enum video_bus_format {
> VIDEO_BUS_FMT_FIXED = 0x0001,
>
> - /* RGB - next is 0x100e */
> + /* RGB - next is 0x1010 */
> VIDEO_BUS_FMT_RGB444_2X8_PADHI_BE = 0x1001,
> VIDEO_BUS_FMT_RGB444_2X8_PADHI_LE = 0x1002,
> VIDEO_BUS_FMT_RGB555_2X8_PADHI_BE = 0x1003,
> @@ -48,6 +48,8 @@ enum video_bus_format {
> VIDEO_BUS_FMT_RGB888_2X12_BE = 0x100b,
> VIDEO_BUS_FMT_RGB888_2X12_LE = 0x100c,
> VIDEO_BUS_FMT_ARGB8888_1X32 = 0x100d,
> + VIDEO_BUS_FMT_RGB444_1X12 = 0x100e,
> + VIDEO_BUS_FMT_RGB565_1X16 = 0x100f,
>
> /* YUV (including grey) - next is 0x2024 */
> VIDEO_BUS_FMT_Y8_1X8 = 0x2001,