2014-11-07 23:40:26

by NeilBrown

[permalink] [raw]

Subject: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.

---

This button is treated as a wakeup source, so we need to initialise it
correctly.

Without the device_init_wakeup() call, dev->power.wakeup will
be NULL, and pm_wakeup_event() will do nothing.

Signed-off-by: NeilBrown <[email protected]>

diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index fb3b63b2f85c..8400a1a34d87 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
}

platform_set_drvdata(pdev, pwr);
+ device_init_wakeup(&pdev->dev, true);

return 0;
}

---

Attachments:

(No filename) (811.00 B)
OpenPGP digital signature

2014-11-08 20:37:06

by Dmitry Torokhov

[permalink] [raw]

Subject: Re: [PATCH] Input: twl4030-pwrbutton: ensure a wakeup event is recorded.

---

On Sat, Nov 08, 2014 at 10:40:15AM +1100, NeilBrown wrote:
>
>
> This button is treated as a wakeup source, so we need to initialise it
> correctly.
>
> Without the device_init_wakeup() call, dev->power.wakeup will
> be NULL, and pm_wakeup_event() will do nothing.
>
> Signed-off-by: NeilBrown <[email protected]>

Applied, thank you.

>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index fb3b63b2f85c..8400a1a34d87 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -85,6 +85,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> }
>
> platform_set_drvdata(pdev, pwr);
> + device_init_wakeup(&pdev->dev, true);
>
> return 0;
> }



--
Dmitry