2014-11-08 00:22:38

by NeilBrown

[permalink] [raw]
Subject: [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.


commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration

claims:
Let's add device tree support and configure things for warm reset
as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.

However the current driver fails to probe with that 'compatible'
setting.
Restore the old default.

Signed-off-by: NeilBrown <[email protected]>

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 4d3ff3771491..1a7794f6be15 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {

static struct of_device_id twl4030_power_of_match[] = {
{
+ .compatible = "ti,twl4030-power",
+ .data = NULL,
+ },
+ {
.compatible = "ti,twl4030-power-reset",
.data = &omap3_reset,
},

Attachments:
(No filename) (811.00 B)
OpenPGP digital signature

2014-11-08 07:24:41

by H. Nikolaus Schaller

[permalink] [raw]
Subject: Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.


Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:

>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.

I think this is a duplicate to

599a1ca80d1d8269d54fdc4abdec8e65141381fe

(in linux-next)

>
> Signed-off-by: NeilBrown <[email protected]>
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },
> _______________________________________________
> Gta04-owner mailing list
> [email protected]
> http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

2014-11-10 01:27:33

by NeilBrown

[permalink] [raw]
Subject: Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
<[email protected]> wrote:

>
> Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:
>
> >
> > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> > mfd: twl4030-power: Add generic reset configuration
> >
> > claims:
> > Let's add device tree support and configure things for warm reset
> > as the default when compatible = "ti,twl4030-power".
> > and
> > Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> >
> > However the current driver fails to probe with that 'compatible'
> > setting.
> > Restore the old default.
>
> I think this is a duplicate to
>
> 599a1ca80d1d8269d54fdc4abdec8e65141381fe
>
> (in linux-next)


Ahh, so it is. Thanks.

NeilBrown


>
> >
> > Signed-off-by: NeilBrown <[email protected]>
> >
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 4d3ff3771491..1a7794f6be15 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> >
> > static struct of_device_id twl4030_power_of_match[] = {
> > {
> > + .compatible = "ti,twl4030-power",
> > + .data = NULL,
> > + },
> > + {
> > .compatible = "ti,twl4030-power-reset",
> > .data = &omap3_reset,
> > },
> > _______________________________________________
> > Gta04-owner mailing list
> > [email protected]
> > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner

Attachments:
(No filename) (811.00 B)
OpenPGP digital signature

2014-11-10 09:07:46

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.

On Sat, 08 Nov 2014, NeilBrown wrote:
>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.
>
> Signed-off-by: NeilBrown <[email protected]>

Tony should take a look at this.

> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },



--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2014-11-10 09:09:12

by Lee Jones

[permalink] [raw]
Subject: Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

On Mon, 10 Nov 2014, NeilBrown wrote:

> On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
> <[email protected]> wrote:
>
> >
> > Am 08.11.2014 um 01:22 schrieb NeilBrown <[email protected]>:
> >
> > >
> > > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> > > mfd: twl4030-power: Add generic reset configuration
> > >
> > > claims:
> > > Let's add device tree support and configure things for warm reset
> > > as the default when compatible = "ti,twl4030-power".
> > > and
> > > Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> > >
> > > However the current driver fails to probe with that 'compatible'
> > > setting.
> > > Restore the old default.
> >
> > I think this is a duplicate to
> >
> > 599a1ca80d1d8269d54fdc4abdec8e65141381fe
> >
> > (in linux-next)
>
>
> Ahh, so it is. Thanks.

Just read this.

Previous reply withdrawn.

> > > Signed-off-by: NeilBrown <[email protected]>
> > >
> > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > > index 4d3ff3771491..1a7794f6be15 100644
> > > --- a/drivers/mfd/twl4030-power.c
> > > +++ b/drivers/mfd/twl4030-power.c
> > > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> > >
> > > static struct of_device_id twl4030_power_of_match[] = {
> > > {
> > > + .compatible = "ti,twl4030-power",
> > > + .data = NULL,
> > > + },
> > > + {
> > > .compatible = "ti,twl4030-power-reset",
> > > .data = &omap3_reset,
> > > },
> > > _______________________________________________
> > > Gta04-owner mailing list
> > > [email protected]
> > > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
>



--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog