Simple style fix (checkpatch.pl: "space prohibited before that ','").
For the eudyptula challenge (http://eudyptula-challenge.org/).
Signed-off-by: Christian F. Resell <[email protected]>
---
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 2bba370..bdc6854 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
* bcm2048_i2c_driver - i2c driver interface
*/
static const struct i2c_device_id bcm2048_id[] = {
- { "bcm2048" , 0 },
+ { "bcm2048", 0 },
{ },
};
MODULE_DEVICE_TABLE(i2c, bcm2048_id);
On 11/15, Christian Resell wrote:
> Simple style fix (checkpatch.pl: "space prohibited before that ','").
> For the eudyptula challenge (http://eudyptula-challenge.org/).
Nice, however we do not need the information about the 'eudyptula
challenge' in the commit message.
If you want to include extra information please do it after the '---'
line (just below the signed-off). You will find more details in the
SubmittingPatches (chapter 15) of the kernel documentation.
Thanks,
Konrad
> Signed-off-by: Christian F. Resell <[email protected]>
> ---
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 2bba370..bdc6854 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> * bcm2048_i2c_driver - i2c driver interface
> */
> static const struct i2c_device_id bcm2048_id[] = {
> - { "bcm2048" , 0 },
> + { "bcm2048", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> On 11/15, Christian Resell wrote:
> > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > For the eudyptula challenge (http://eudyptula-challenge.org/).
>
> Nice, however we do not need the information about the 'eudyptula
> challenge' in the commit message.
>
> If you want to include extra information please do it after the '---'
> line (just below the signed-off). You will find more details in the
> SubmittingPatches (chapter 15) of the kernel documentation.
Greg is staging tree maintainer... And if single extra space is all
you can fix in the driver, perhaps it is not worth the patch?
Pavel
> Thanks,
> Konrad
>
> > Signed-off-by: Christian F. Resell <[email protected]>
> > ---
> > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > index 2bba370..bdc6854 100644
> > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> > * bcm2048_i2c_driver - i2c driver interface
> > */
> > static const struct i2c_device_id bcm2048_id[] = {
> > - { "bcm2048" , 0 },
> > + { "bcm2048", 0 },
> > { },
> > };
> > MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> > _______________________________________________
> > devel mailing list
> > [email protected]
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
> On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > On 11/15, Christian Resell wrote:
> > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> >
> > Nice, however we do not need the information about the 'eudyptula
> > challenge' in the commit message.
> >
> > If you want to include extra information please do it after the '---'
> > line (just below the signed-off). You will find more details in the
> > SubmittingPatches (chapter 15) of the kernel documentation.
>
> Greg is staging tree maintainer... And if single extra space is all
> you can fix in the driver, perhaps it is not worth the patch?
I am not the maintainer of drivers/staging/media/ please look at
MAINTAINERS before you make statements like that.
And yes, one space fixes is just fine, that's why the code is in
staging.
greg k-h
On 11/15, Pavel Machek wrote:
> On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > On 11/15, Christian Resell wrote:
> > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> >
> > Nice, however we do not need the information about the 'eudyptula
> > challenge' in the commit message.
> >
> > If you want to include extra information please do it after the '---'
> > line (just below the signed-off). You will find more details in the
> > SubmittingPatches (chapter 15) of the kernel documentation.
>
> Greg is staging tree maintainer... And if single extra space is all
> you can fix in the driver, perhaps it is not worth the patch?
I think that every contribution, as long as it acctually fixes
something, is worth the patch. The beauty of the open source community
is that we do when we have time as much as we are able to do - totally
no stress.
You, Pavel, are more experienced however those who are not have to learn
somehow and one of the options is to start with something very simple.
Sometimes the 'simple' means oneliner however as long as it compiles, is
inline with the coding standard and in general is an improvement then it
is good.
Regards,
Konrad
> Pavel
>
> > Thanks,
> > Konrad
> >
> > > Signed-off-by: Christian F. Resell <[email protected]>
> > > ---
> > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > index 2bba370..bdc6854 100644
> > > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> > > * bcm2048_i2c_driver - i2c driver interface
> > > */
> > > static const struct i2c_device_id bcm2048_id[] = {
> > > - { "bcm2048" , 0 },
> > > + { "bcm2048", 0 },
> > > { },
> > > };
> > > MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> > > _______________________________________________
> > > devel mailing list
> > > [email protected]
> > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Em Sat, 15 Nov 2014 13:25:03 -0800
Greg KH <[email protected]> escreveu:
> On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
> > On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > > On 11/15, Christian Resell wrote:
> > > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> > >
> > > Nice, however we do not need the information about the 'eudyptula
> > > challenge' in the commit message.
> > >
> > > If you want to include extra information please do it after the '---'
> > > line (just below the signed-off). You will find more details in the
> > > SubmittingPatches (chapter 15) of the kernel documentation.
> >
> > Greg is staging tree maintainer... And if single extra space is all
> > you can fix in the driver, perhaps it is not worth the patch?
>
> I am not the maintainer of drivers/staging/media/ please look at
> MAINTAINERS before you make statements like that.
>
> And yes, one space fixes is just fine, that's why the code is in
> staging.
Yes, space fixes is OK for staging.
I'll apply this patch, removing the line that comments about the challenge,
as we don't need to keep this information forever at the Kernel history.
Regards,
Mauro