2014-11-14 02:12:11

by Zhen Lei

Subject: [PATCH 1/1] clk: delete a local variable's repeated assignment

It's the same to the next statement, "ret = clk->parent". I think compiler will
optimize it, it's just not looking well.

Signed-off-by: Zhen Lei <[email protected]>
---
drivers/clk/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 4896ae9..5307225 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk)

if (clk->num_parents == 1) {
if (IS_ERR_OR_NULL(clk->parent))
- ret = clk->parent = __clk_lookup(clk->parent_names[0]);
+ clk->parent = __clk_lookup(clk->parent_names[0]);
ret = clk->parent;
goto out;
}
--
1.8.0

2014-11-18 22:35:44

by Mike Turquette

Subject: Re: [PATCH 1/1] clk: delete a local variable's repeated assignment

Quoting Zhen Lei (2014-11-13 18:10:40)
> It's the same to the next statement, "ret = clk->parent". I think compiler will
> optimize it, it's just not looking well.
>
> Signed-off-by: Zhen Lei <[email protected]>

Applied.

Thanks,
Mike

> ---
> drivers/clk/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 4896ae9..5307225 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk)
>
> if (clk->num_parents == 1) {
> if (IS_ERR_OR_NULL(clk->parent))
> - ret = clk->parent = __clk_lookup(clk->parent_names[0]);
> + clk->parent = __clk_lookup(clk->parent_names[0]);
> ret = clk->parent;
> goto out;
> }
> --
> 1.8.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/