2014-11-22 07:44:10

by Anjana Sasindran

Subject: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

This patch fixes the checkpatch.pl error:

ERROR: trailing whitespace

Signed-off-by: Anjana Sasindran <[email protected]>
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 7096d5a..268e4de 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -188,7 +188,6 @@ static int __init skein_generic_init(void)
goto unreg256;
if (crypto_register_shash(&alg1024))
goto unreg512;
-
return 0;
unreg512:
crypto_unregister_shash(&alg512);
--
1.9.1

2014-11-22 08:31:14

by Sudip Mukherjee

Subject: Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
it still does not apply to next-20141121
> ERROR: trailing whitespace

and i am not seeing any trailing whitespace at line 191 of this file.
if you base your patch on next-20141121 your patch should have been:

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 60d16b6..8660509 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)

return 0;

-
unreg512:
crypto_unregister_shash(&alg512);
unreg256:


thanks
sudip

>
> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..268e4de 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -188,7 +188,6 @@ static int __init skein_generic_init(void)
> goto unreg256;
> if (crypto_register_shash(&alg1024))
> goto unreg512;
> -
> return 0;
> unreg512:
> crypto_unregister_shash(&alg512);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2014-11-22 18:59:59

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
>
> ERROR: trailing whitespace
>
> Signed-off-by: Anjana Sasindran <[email protected]>
> ---
> drivers/staging/skein/skein_generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..268e4de 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -188,7 +188,6 @@ static int __init skein_generic_init(void)
> goto unreg256;
> if (crypto_register_shash(&alg1024))
> goto unreg512;
> -
> return 0;
> unreg512:
> crypto_unregister_shash(&alg512);

Your changelog body does not match the patch :(