2014-11-21 12:23:30

by Jiri Slaby

Subject: [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc

It referenced of_property_read_string_util whereas the function name
is of_property_read_string_helper.

Introduced in a87fa1d81a9fb5e9adca9820e16008c40ad09f33 (of: Fix
overflow bug in string property parsing functions). Found out when
reviewing the stable 3.12 queue.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Mika Westerberg <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Darren Hart <[email protected]>
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 37de43ef22fc..76d8307a1cd5 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1359,7 +1359,7 @@ int of_property_match_string(struct device_node *np, const char *propname,
EXPORT_SYMBOL_GPL(of_property_match_string);

/**
- * of_property_read_string_util() - Utility helper for parsing string properties
+ * of_property_read_string_helper() - Utility helper for parsing string properties
* @np: device node from which the property value is to be read.
* @propname: name of the property to be searched.
* @out_strs: output array of string pointers.
--
2.1.3

2014-11-26 13:27:59

by Grant Likely

Subject: Re: [PATCH 1/1] of: base, fix of_property_read_string_helper kernel-doc

On Fri, 21 Nov 2014 13:23:09 +0100
, Jiri Slaby <[email protected]>
wrote:
> It referenced of_property_read_string_util whereas the function name
> is of_property_read_string_helper.
>
> Introduced in a87fa1d81a9fb5e9adca9820e16008c40ad09f33 (of: Fix
> overflow bug in string property parsing functions). Found out when
> reviewing the stable 3.12 queue.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Mika Westerberg <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Darren Hart <[email protected]>

Applied, thanks.

g.

> ---
> drivers/of/base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 37de43ef22fc..76d8307a1cd5 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1359,7 +1359,7 @@ int of_property_match_string(struct device_node *np, const char *propname,
> EXPORT_SYMBOL_GPL(of_property_match_string);
>
> /**
> - * of_property_read_string_util() - Utility helper for parsing string properties
> + * of_property_read_string_helper() - Utility helper for parsing string properties
> * @np: device node from which the property value is to be read.
> * @propname: name of the property to be searched.
> * @out_strs: output array of string pointers.
> --
> 2.1.3
>