2014-11-29 11:24:16

by Ganesh Mahendran

Subject: [RFC PATCH] mm/zsmalloc: allocate exactly size of struct zs_pool

In zs_create_pool(), we allocate memory more then sizeof(struct zs_pool)
ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);

This patch allocate memory of exactly needed size.

Signed-off-by: Ganesh Mahendran <[email protected]>
---
mm/zsmalloc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2021df5..4d0a063 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -979,12 +979,11 @@ static bool can_merge(struct size_class *prev, int size, int pages_per_zspage)
*/
struct zs_pool *zs_create_pool(gfp_t flags)
{
- int i, ovhd_size;
+ int i;
struct zs_pool *pool;
struct size_class *prev_class = NULL;

- ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);
- pool = kzalloc(ovhd_size, GFP_KERNEL);
+ pool = kzalloc(sizeof(*pool), GFP_KERNEL);
if (!pool)
return NULL;

--
1.7.9.5

2014-12-01 00:29:30

by Minchan Kim

Subject: Re: [RFC PATCH] mm/zsmalloc: allocate exactly size of struct zs_pool

On Sat, Nov 29, 2014 at 07:23:55PM +0800, Ganesh Mahendran wrote:
> In zs_create_pool(), we allocate memory more then sizeof(struct zs_pool)
> ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);
>
> This patch allocate memory of exactly needed size.
>
> Signed-off-by: Ganesh Mahendran <[email protected]>
Acked-by: Minchan Kim <[email protected]>

--
Kind regards,
Minchan Kim