2014-12-02 17:08:03

by Michele Curti

Subject: [PATCH] drivers/dma/pch_dma: declare pch_dma_id_table as static

pch_dma_id_table is used in pch_dma.c only, so declare
it as static

Signed-off-by: Michele Curti <[email protected]>
---
drivers/dma/pch_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 9f9ca9f..6e0e47d 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -997,7 +997,7 @@ static void pch_dma_remove(struct pci_dev *pdev)
#define PCI_DEVICE_ID_ML7831_DMA1_8CH 0x8810
#define PCI_DEVICE_ID_ML7831_DMA2_4CH 0x8815

-const struct pci_device_id pch_dma_id_table[] = {
+static const struct pci_device_id pch_dma_id_table[] = {
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_EG20T_PCH_DMA_8CH), 8 },
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_EG20T_PCH_DMA_4CH), 4 },
{ PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7213_DMA1_8CH), 8}, /* UART Video */
--
2.1.3

2014-12-05 17:59:18

by Vinod Koul

Subject: Re: [PATCH] drivers/dma/pch_dma: declare pch_dma_id_table as static

On Tue, Dec 02, 2014 at 06:07:56PM +0100, Michele Curti wrote:
> pch_dma_id_table is used in pch_dma.c only, so declare
> it as static
Applied, thanks

--
~Vinod

>
> Signed-off-by: Michele Curti <[email protected]>
> ---
> drivers/dma/pch_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 9f9ca9f..6e0e47d 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -997,7 +997,7 @@ static void pch_dma_remove(struct pci_dev *pdev)
> #define PCI_DEVICE_ID_ML7831_DMA1_8CH 0x8810
> #define PCI_DEVICE_ID_ML7831_DMA2_4CH 0x8815
>
> -const struct pci_device_id pch_dma_id_table[] = {
> +static const struct pci_device_id pch_dma_id_table[] = {
> { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_EG20T_PCH_DMA_8CH), 8 },
> { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_EG20T_PCH_DMA_4CH), 4 },
> { PCI_VDEVICE(ROHM, PCI_DEVICE_ID_ML7213_DMA1_8CH), 8}, /* UART Video */
> --
> 2.1.3
>

--