2014-12-07 17:54:17

by Rickard Strandqvist

Subject: [PATCH] arch: powerpc: kernel: sys_ppc32.c: Remove unused function

Remove the function compat_sys_mmap2() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
arch/powerpc/kernel/sys_ppc32.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c
index 8a28587..8f32cf8 100644
--- a/arch/powerpc/kernel/sys_ppc32.c
+++ b/arch/powerpc/kernel/sys_ppc32.c
@@ -61,14 +61,6 @@ asmlinkage long ppc32_select(u32 n, compat_ulong_t __user *inp,
return compat_sys_select((int)n, inp, outp, exp, compat_ptr(tvp_x));
}

-unsigned long compat_sys_mmap2(unsigned long addr, size_t len,
- unsigned long prot, unsigned long flags,
- unsigned long fd, unsigned long pgoff)
-{
- /* This should remain 12 even if PAGE_SIZE changes */
- return sys_mmap(addr, len, prot, flags, fd, pgoff << 12);
-}
-
/*
* long long munging:
* The 32 bit ABI passes long longs in an odd even register pair.
--
1.7.10.4

2014-12-08 01:09:11

by Paul Mackerras

Subject: Re: [PATCH] arch: powerpc: kernel: sys_ppc32.c: Remove unused function

On Sun, Dec 07, 2014 at 06:56:54PM +0100, Rickard Strandqvist wrote:
> Remove the function compat_sys_mmap2() that is not used anywhere.

It's referenced in 64-bit kernels from arch/powerpc/kernel/systbl.S,
via the SYS32ONLY(mmap2) line in arch/powerpc/include/asm/systbl.h.

Paul.