Hi Mark,
After merging the spi tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/spi/spi-dln2.c: In function 'dln2_spi_copy_from_buf':
drivers/spi/spi-dln2.c:415:4: error: implicit declaration of function 'get_unaligned_le32' [-Werror=implicit-function-declaration]
*d++ = get_unaligned_le32(s++);
^
Caused by commit ffb9ad0a47b4 ("spi: add support for DLN-2 USB-SPI adapter").
drivers/spi/spi-st-ssc4.c: In function 'spi_st_remove':
drivers/spi/spi-st-ssc4.c:427:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
pinctrl_pm_select_sleep_state(&pdev->dev);
^
drivers/spi/spi-st-ssc4.c: In function 'spi_st_runtime_resume':
drivers/spi/spi-st-ssc4.c:453:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
pinctrl_pm_select_default_state(dev);
^
Caused by commit cf9e9c98fa8c ("spi: Add new driver for
STMicroelectronics' SPI Controller").
To me COMPILE_TEST means "this builds everywhere, make sure it doesn't
break" ... not "lets set this and see if Stephen finds anything" :-)
I reverted both commits for today.
--
Cheers,
Stephen Rothwell [email protected]
On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote:
> Caused by commit cf9e9c98fa8c ("spi: Add new driver for
> STMicroelectronics' SPI Controller").
> To me COMPILE_TEST means "this builds everywhere, make sure it doesn't
> break" ... not "lets set this and see if Stephen finds anything" :-)
> I reverted both commits for today.
I've dropped both from my tree too.
On Mon, 08 Dec 2014, Mark Brown wrote:
> On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote:
>
> > Caused by commit cf9e9c98fa8c ("spi: Add new driver for
> > STMicroelectronics' SPI Controller").
>
> > To me COMPILE_TEST means "this builds everywhere, make sure it doesn't
> > break" ... not "lets set this and see if Stephen finds anything" :-)
>
> > I reverted both commits for today.
>
> I've dropped both from my tree too.
Patches re-sent without COMPILE_TEST support.
I will re-enable COMPILE_TEST when Will Deacon's patch to fix this
kind of nonsense lands.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Mon, Dec 08, 2014 at 12:54:47PM +0000, Lee Jones wrote:
> Patches re-sent without COMPILE_TEST support.
> I will re-enable COMPILE_TEST when Will Deacon's patch to fix this
> kind of nonsense lands.
It wasn't the _relaxed() stuff that was triggering, it was implicit
inclusions of the pinctrl headers. You need to directly include them
rather than relying on some other header pulling them in.
On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote:
> Hi Mark,
>
> After merging the spi tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/spi/spi-dln2.c: In function 'dln2_spi_copy_from_buf':
> drivers/spi/spi-dln2.c:415:4: error: implicit declaration of function 'get_unaligned_le32' [-Werror=implicit-function-declaration]
> *d++ = get_unaligned_le32(s++);
> ^
>
> Caused by commit ffb9ad0a47b4 ("spi: add support for DLN-2 USB-SPI adapter").
Re-sent the patch with the asm/unaligned.h header included and I build tested
for PPC to make sure.
Sorry for the trouble... :/
laurentiu