2014-12-09 13:20:05

by weiyj_lk

[permalink] [raw]
Subject: [PATCH -next] regulator: rk808: Fix sparse non static symbol warnings

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

drivers/regulator/rk808-regulator.c:100:5: warning:
symbol 'rk808_set_suspend_voltage' was not declared. Should it be static?
drivers/regulator/rk808-regulator.c:115:5: warning:
symbol 'rk808_set_suspend_enable' was not declared. Should it be static?
drivers/regulator/rk808-regulator.c:126:5: warning:
symbol 'rk808_set_suspend_disable' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/regulator/rk808-regulator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index ea9d05e..8c2c57a 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -97,7 +97,7 @@ static int rk808_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
RK808_RAMP_RATE_MASK, ramp_value);
}

-int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
+static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
{
unsigned int reg;
int sel = regulator_map_voltage_linear_range(rdev, uv, uv);
@@ -112,7 +112,7 @@ int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
sel);
}

-int rk808_set_suspend_enable(struct regulator_dev *rdev)
+static int rk808_set_suspend_enable(struct regulator_dev *rdev)
{
unsigned int reg;

@@ -123,7 +123,7 @@ int rk808_set_suspend_enable(struct regulator_dev *rdev)
0);
}

-int rk808_set_suspend_disable(struct regulator_dev *rdev)
+static int rk808_set_suspend_disable(struct regulator_dev *rdev)
{
unsigned int reg;


2014-12-09 16:18:31

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] regulator: rk808: Fix sparse non static symbol warnings

On Tue, Dec 09, 2014 at 09:19:51PM +0800, [email protected] wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warnings:

Applied, thanks.


Attachments:
(No filename) (178.00 B)
signature.asc (473.00 B)
Digital signature
Download all attachments