2014-12-10 13:28:21

by Christian Borntraeger

Subject: [PATCH] perf kvm stat live: mark events as (x86 only) in help output

From: Alexander Yarygin <[email protected]>

The mmio and ioport events are useful only on x86.

Signed-off-by: Alexander Yarygin <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
---
tools/perf/builtin-kvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index b65eb050..612e8f9 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1268,7 +1268,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
OPT_UINTEGER('d', "display", &kvm->display_time,
"time in seconds between display updates"),
OPT_STRING(0, "event", &kvm->report_event, "report event",
- "event for reporting: vmexit, mmio, ioport"),
+ "event for reporting: "
+ "vmexit, mmio (x86 only), ioport (x86 only)"),
OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
"vcpu id to report"),
OPT_STRING('k', "key", &kvm->sort_key, "sort-key",
--
1.9.3

2014-12-10 13:57:19

by David Ahern

Subject: Re: [PATCH] perf kvm stat live: mark events as (x86 only) in help output

On 12/10/14 6:28 AM, Christian Borntraeger wrote:
> From: Alexander Yarygin <[email protected]>
>
> The mmio and ioport events are useful only on x86.
>
> Signed-off-by: Alexander Yarygin <[email protected]>
> Signed-off-by: Christian Borntraeger <[email protected]>
> ---
> tools/perf/builtin-kvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
> index b65eb050..612e8f9 100644
> --- a/tools/perf/builtin-kvm.c
> +++ b/tools/perf/builtin-kvm.c
> @@ -1268,7 +1268,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
> OPT_UINTEGER('d', "display", &kvm->display_time,
> "time in seconds between display updates"),
> OPT_STRING(0, "event", &kvm->report_event, "report event",
> - "event for reporting: vmexit, mmio, ioport"),
> + "event for reporting: "
> + "vmexit, mmio (x86 only), ioport (x86 only)"),
> OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
> "vcpu id to report"),
> OPT_STRING('k', "key", &kvm->sort_key, "sort-key",
>

Acked-by: David Ahern <[email protected]>

2014-12-10 15:10:18

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf kvm stat live: mark events as (x86 only) in help output

Em Wed, Dec 10, 2014 at 06:57:13AM -0700, David Ahern escreveu:
> On 12/10/14 6:28 AM, Christian Borntraeger wrote:
> >diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
> > OPT_STRING(0, "event", &kvm->report_event, "report event",
> >- "event for reporting: vmexit, mmio, ioport"),
> >+ "event for reporting: "
> >+ "vmexit, mmio (x86 only), ioport (x86 only)"),
>
> Acked-by: David Ahern <[email protected]>

Thanks, applied to my local perf/core branch.

- Arnaldo

2014-12-12 08:19:09

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf kvm stat live: Mark events as (x86 only) in help output

Commit-ID: 99d348a84c2118ed04c9b72168787f55e2fe33a5
Gitweb: http://git.kernel.org/tip/99d348a84c2118ed04c9b72168787f55e2fe33a5
Author: Alexander Yarygin <[email protected]>
AuthorDate: Wed, 10 Dec 2014 14:28:10 +0100
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 10 Dec 2014 12:08:59 -0300

perf kvm stat live: Mark events as (x86 only) in help output

The mmio and ioport events are useful only on x86.

Signed-off-by: Alexander Yarygin <[email protected]>
Acked-by: David Ahern <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: Jiri Olsa <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-kvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 3c0f3d4..0894a81 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1293,7 +1293,8 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
OPT_UINTEGER('d', "display", &kvm->display_time,
"time in seconds between display updates"),
OPT_STRING(0, "event", &kvm->report_event, "report event",
- "event for reporting: vmexit, mmio, ioport"),
+ "event for reporting: "
+ "vmexit, mmio (x86 only), ioport (x86 only)"),
OPT_INTEGER(0, "vcpu", &kvm->trace_vcpu,
"vcpu id to report"),
OPT_STRING('k', "key", &kvm->sort_key, "sort-key",