2014-12-10 19:19:11

by KY Srinivasan

Subject: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

Fix a bug in vmbus_establish_gpadl(). I would like to
thank Michael Brown <[email protected]> for seeing this bug.
In this version, I have added the Reported-by tag.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Reported-by: Michael Brown <[email protected]>
---
drivers/hv/channel.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 433f72a..c76ffbe 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -366,8 +366,8 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
unsigned long flags;
int ret = 0;

- next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle);
- atomic_inc(&vmbus_connection.next_gpadl_handle);
+ next_gpadl_handle =
+ (atomic_inc_return(&vmbus_connection.next_gpadl_handle) - 1);

ret = create_gpadl_header(kbuffer, size, &msginfo, &msgcount);
if (ret)
--
1.7.4.1

2014-12-10 21:45:50

by Jeremiah Mahler

Subject: Re: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

K. Y. Srinivasan,

On Wed, Dec 10, 2014 at 12:29:19PM -0800, K. Y. Srinivasan wrote:
> Fix a bug in vmbus_establish_gpadl(). I would like to
> thank Michael Brown <[email protected]> for seeing this bug.
> In this version, I have added the Reported-by tag.

The log message should be more specific. "Fix a bug" is too vague.
Why is this patch necessary? What bug does it fix? What changes did you
make?

Saying you have "added the Reported-by tag" is not helpful in a log
message. Although you can add notes for the patch reviewer under '---'.

> Signed-off-by: K. Y. Srinivasan <[email protected]>
> Reported-by: Michael Brown <[email protected]>
You followed Gregs advice [1], good :-)

[1]: https://lkml.org/lkml/2014/12/10/495

> ---
I like to list the changes I make in patch revisions here:

Changes in V2:
Added Reported-by tag for Michael Brown <[email protected]>

> drivers/hv/channel.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 433f72a..c76ffbe 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -366,8 +366,8 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
> unsigned long flags;
> int ret = 0;
>
> - next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle);
> - atomic_inc(&vmbus_connection.next_gpadl_handle);
> + next_gpadl_handle =
> + (atomic_inc_return(&vmbus_connection.next_gpadl_handle) - 1);
>
> ret = create_gpadl_header(kbuffer, size, &msginfo, &msgcount);
> if (ret)
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
- Jeremiah Mahler

2014-12-11 00:02:07

by KY Srinivasan

Subject: RE: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

> -----Original Message-----
> From: Jeremiah Mahler [mailto:[email protected]]
> Sent: Wednesday, December 10, 2014 1:46 PM
> To: KY Srinivasan
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in
> vmbus_establish_gpadl()
>
> K. Y. Srinivasan,
>
> On Wed, Dec 10, 2014 at 12:29:19PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in vmbus_establish_gpadl(). I would like to thank Michael
> > Brown <[email protected]> for seeing this bug.
> > In this version, I have added the Reported-by tag.
>
> The log message should be more specific. "Fix a bug" is too vague.
> Why is this patch necessary? What bug does it fix? What changes did you
> make?
>
> Saying you have "added the Reported-by tag" is not helpful in a log message.
> Although you can add notes for the patch reviewer under '---'.

Thank you; I will fix up the log and resend.

K. Y