2014-12-09 01:07:48

by weiyj_lk

Subject: [PATCH -next] clk: mmp: fix sparse non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

drivers/clk/mmp/clk-frac.c:113:6: warning:
symbol 'clk_factor_init' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/clk/mmp/clk-frac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mmp/clk-frac.c b/drivers/clk/mmp/clk-frac.c
index eeba52c..584a992 100644
--- a/drivers/clk/mmp/clk-frac.c
+++ b/drivers/clk/mmp/clk-frac.c
@@ -110,7 +110,7 @@ static int clk_factor_set_rate(struct clk_hw *hw, unsigned long drate,
return 0;
}

-void clk_factor_init(struct clk_hw *hw)
+static void clk_factor_init(struct clk_hw *hw)
{
struct mmp_clk_factor *factor = to_clk_factor(hw);
struct mmp_clk_factor_masks *masks = factor->masks;

2014-12-11 20:14:37

by Mike Turquette

Subject: Re: [PATCH -next] clk: mmp: fix sparse non static symbol warning

Quoting [email protected] (2014-12-08 17:07:30)
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warnings:
>
> drivers/clk/mmp/clk-frac.c:113:6: warning:
> symbol 'clk_factor_init' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied.

Thanks,
Mike

> ---
> drivers/clk/mmp/clk-frac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mmp/clk-frac.c b/drivers/clk/mmp/clk-frac.c
> index eeba52c..584a992 100644
> --- a/drivers/clk/mmp/clk-frac.c
> +++ b/drivers/clk/mmp/clk-frac.c
> @@ -110,7 +110,7 @@ static int clk_factor_set_rate(struct clk_hw *hw, unsigned long drate,
> return 0;
> }
>
> -void clk_factor_init(struct clk_hw *hw)
> +static void clk_factor_init(struct clk_hw *hw)
> {
> struct mmp_clk_factor *factor = to_clk_factor(hw);
> struct mmp_clk_factor_masks *masks = factor->masks;
>