2014-12-12 16:32:52

by Fengguang Wu

[permalink] [raw]
Subject: [iio:testing 44/44] drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?

tree: git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
head: fd3ae7a9f21c2a51a1d220bc7a7c3b45ab5e6ad1
commit: fd3ae7a9f21c2a51a1d220bc7a7c3b45ab5e6ad1 [44/44] iio: imu: kmx61: Add support for any motion trigger
reproduce:
# apt-get install sparse
git checkout fd3ae7a9f21c2a51a1d220bc7a7c3b45ab5e6ad1
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation


2014-12-12 16:32:54

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH iio] iio: imu: kmx61: kmx61_set_wake_up_odr() can be static

drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <[email protected]>
---
kmx61.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
index bda9c40..9b32f01 100644
--- a/drivers/iio/imu/kmx61.c
+++ b/drivers/iio/imu/kmx61.c
@@ -419,7 +419,7 @@ static int kmx61_get_mode(struct kmx61_data *data, u8 *mode, u8 device)
return 0;
}

-int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
+static int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
{
int ret, odr_bits;

2014-12-12 16:41:19

by Daniel Baluta

[permalink] [raw]
Subject: Re: [PATCH iio] iio: imu: kmx61: kmx61_set_wake_up_odr() can be static

On Fri, Dec 12, 2014 at 6:28 PM, kbuild test robot
<[email protected]> wrote:
> drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <[email protected]>

Reviewed-by: Daniel Baluta <[email protected]>

> ---
> kmx61.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index bda9c40..9b32f01 100644
> --- a/drivers/iio/imu/kmx61.c
> +++ b/drivers/iio/imu/kmx61.c
> @@ -419,7 +419,7 @@ static int kmx61_get_mode(struct kmx61_data *data, u8 *mode, u8 device)
> return 0;
> }
>
> -int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
> +static int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
> {
> int ret, odr_bits;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2014-12-12 18:15:42

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH iio] iio: imu: kmx61: kmx61_set_wake_up_odr() can be static

On 12/12/14 16:41, Daniel Baluta wrote:
> On Fri, Dec 12, 2014 at 6:28 PM, kbuild test robot
> <[email protected]> wrote:
>> drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?
>>
>> Signed-off-by: Fengguang Wu <[email protected]>
>
> Reviewed-by: Daniel Baluta <[email protected]>
Applied to the togreg branch of iio.git.

Thanks!

Jonathan
>
>> ---
>> kmx61.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
>> index bda9c40..9b32f01 100644
>> --- a/drivers/iio/imu/kmx61.c
>> +++ b/drivers/iio/imu/kmx61.c
>> @@ -419,7 +419,7 @@ static int kmx61_get_mode(struct kmx61_data *data, u8 *mode, u8 device)
>> return 0;
>> }
>>
>> -int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
>> +static int kmx61_set_wake_up_odr(struct kmx61_data *data, int val, int val2)
>> {
>> int ret, odr_bits;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>