2014-12-15 07:22:14

by Asaf Vertz

[permalink] [raw]
Subject: [PATCH] usb: host: max3421-hcd: use time_after()

To be future-proof and for better readability the time comparisons are
modified to use time_after() instead of plain, error-prone math.

Signed-off-by: Asaf Vertz <[email protected]>
---
drivers/usb/host/max3421-hcd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index 6234c75..aaaff94 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -55,6 +55,7 @@
* single thread (max3421_spi_thread).
*/

+#include <linux/jiffies.h>
#include <linux/module.h>
#include <linux/spi/spi.h>
#include <linux/usb.h>
@@ -1291,7 +1292,7 @@ max3421_handle_irqs(struct usb_hcd *hcd)
char sbuf[16 * 16], *dp, *end;
int i;

- if (jiffies - last_time > 5*HZ) {
+ if (time_after(jiffies, last_time + 5*HZ)) {
dp = sbuf;
end = sbuf + sizeof(sbuf);
*dp = '\0';
--
1.7.0.4


2014-12-15 07:50:42

by David Mosberger-Tang

[permalink] [raw]
Subject: Re: [PATCH] usb: host: max3421-hcd: use time_after()

Acked-by: David Mosberger <[email protected]>

On Mon, Dec 15, 2014 at 8:22 AM, Asaf Vertz <[email protected]> wrote:
> To be future-proof and for better readability the time comparisons are
> modified to use time_after() instead of plain, error-prone math.
>
> Signed-off-by: Asaf Vertz <[email protected]>
> ---
> drivers/usb/host/max3421-hcd.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
> index 6234c75..aaaff94 100644
> --- a/drivers/usb/host/max3421-hcd.c
> +++ b/drivers/usb/host/max3421-hcd.c
> @@ -55,6 +55,7 @@
> * single thread (max3421_spi_thread).
> */
>
> +#include <linux/jiffies.h>
> #include <linux/module.h>
> #include <linux/spi/spi.h>
> #include <linux/usb.h>
> @@ -1291,7 +1292,7 @@ max3421_handle_irqs(struct usb_hcd *hcd)
> char sbuf[16 * 16], *dp, *end;
> int i;
>
> - if (jiffies - last_time > 5*HZ) {
> + if (time_after(jiffies, last_time + 5*HZ)) {
> dp = sbuf;
> end = sbuf + sizeof(sbuf);
> *dp = '\0';
> --
> 1.7.0.4
>



--
eGauge Systems LLC, http://egauge.net/, 1.877-EGAUGE1, fax 720.545.9768